Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for variables #44

Open
bbetter opened this issue Oct 15, 2019 · 6 comments
Open

Support for variables #44

bbetter opened this issue Oct 15, 2019 · 6 comments
Assignees

Comments

@bbetter
Copy link

bbetter commented Oct 15, 2019

It would be nice to have support for something like this
a = 1
b = a
c = (a+b)*10

At first glance it looks pretty easy to implement, by simply creating inside map of variables and using it to substitute each expression it can find throughout all expression lines

It would be harder if you used your own expression parsing logic but as you seem to just evaluate expressions through mathjs, it seems doable in one PR if without any optimizations.
Actually I created one implementation, but I can't create branch in here to make PR, i'm not sure what's with forks though

@eMerzh
Copy link

eMerzh commented Nov 29, 2019

hey,

i'm also really instersted in this 👍 could you publish your ppr somewhere?

@huonggiangbui
Copy link

Interested. Can I work on it

@basta
Copy link

basta commented Dec 1, 2020

Has there been any progress? I miss this feature as well and am creating my own implementation

@sarthology
Copy link
Collaborator

Feel free to do that :)

@basta
Copy link

basta commented Dec 1, 2020

Not sure if this is the right place to ask. But I can't seem to find it anywhere.

First, do you have any coding standards written down anywhere?

And second when commiting a npm lint hook is preventing me to do so because of 60-70 errors/warnings. Is that normal? Currently I have to use --no-verify option

@basta
Copy link

basta commented Dec 4, 2020

#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants