Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of button content #1220

Open
2 tasks done
trueqbit opened this issue Nov 27, 2023 · 97 comments · May be fixed by #1710
Open
2 tasks done

Alignment of button content #1220

trueqbit opened this issue Nov 27, 2023 · 97 comments · May be fixed by #1710

Comments

@trueqbit
Copy link

trueqbit commented Nov 27, 2023

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Description

I am using hanko-elements for login functionality in a web application.
The CSS for the wrapper of a button icon explicitly sets width and flex alignment:

.hanko_loadingSpinnerWrapperIcon {
  justify-content: center;
  width: 100%;
  column-gap: 10px;
  margin-left: 10px;
}

This makes it currently impossible to align the button content (icon and text) using the shadow DOM.

Describe your ideal solution

The ideal would probably be a CSS variable or respect alignment of the parent ::part(button).

Workarounds or alternatives

No response

Hanko Version

v0.9.0

Additional Context

The background is that I want to center-align the content of the button in the same way as usual in our application, also I find it a bit inconsistent with the alignment of the "Continue" button when all form elements are stacked.

A few screenshots show what it currently looks like:
Login challenge form:
Create Passkey form:

@trueqbit trueqbit added the enhancement New feature or request label Nov 27, 2023
@dhananjay-Byte
Copy link

hey @trueqbit i would like to work on this can you please assign me this?

@trueqbit
Copy link
Author

hey @trueqbit i would like to work on this can you please assign me this?

@dhananjay-Byte As I am not a contributor, I cannot change the metadata of a ticket...

@trueqbit
Copy link
Author

hey @trueqbit i would like to work on this can you please assign me this?

@dhananjay-Byte As I am not a contributor, I cannot change the metadata of a ticket...

@dhananjay-Byte Is there any progress here?

@FlxMgdnz
Copy link
Member

@trueqbit I'm assuming that you want to center-align the buttons, right?

@ahadalichowdhury
Copy link

@FlxMgdnz can i contribute on this issue??

@akash1812
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @akash1812! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@akash1812
Copy link

Can I use the approach where it allows developers to modify alignment through custom css properties?

@awsmdeep
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Anjalisharma3463
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@ItsVicky25
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Vishal-Agg1
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@thisissushant
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@poswalsameer
Copy link

Hi @trueqbit, any screenshot available would help a lot in finding the exact issue that you are facing in the UI. If possible, can you provide screenshots or exactly tell where you found this issue?

@vdhruvannaidu
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@Sahil-Husen
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@siddhakdak
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 15, 2024

Assigned to @hamidayubdev! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@nil-frontend
Copy link

/assign

Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

@Anonymous096
Copy link

/assign

Copy link

oss-gg bot commented Oct 16, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 17, 2024

@hamidayubdev, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 17, 2024

@Ryadav0654, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@HSRAKTU
Copy link

HSRAKTU commented Oct 17, 2024

/assign

Copy link

oss-gg bot commented Oct 17, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 17, 2024

@Pushpender1122, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@AmanSagar0607
Copy link

/assign

Copy link

oss-gg bot commented Oct 17, 2024

This issue is already assigned to another person. Please find more issues here.

@Awais142
Copy link

/assign

Copy link

oss-gg bot commented Oct 18, 2024

This issue is already assigned to another person. Please find more issues here.

@DanishAliUmar
Copy link

/assign

Copy link

oss-gg bot commented Oct 18, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 19, 2024

@hamidayubdev, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@mohdshubair313
Copy link

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

@sanyamhbtu
Copy link

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

1 similar comment
Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

@Shahab-16
Copy link

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 19, 2024

@Pushpender1122, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 21, 2024

@hamidayubdev, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@Sarthak102
Copy link

/assign

Copy link

oss-gg bot commented Oct 27, 2024

This issue is already assigned to another person. Please find more issues here.

@prithak01
Copy link

/assign

Copy link

oss-gg bot commented Oct 28, 2024

This issue is already assigned to another person. Please find more issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.