Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider backporting rackup fix #2706 to 3.39.x #2763

Open
JonRowe opened this issue Jun 19, 2024 · 0 comments
Open

Consider backporting rackup fix #2706 to 3.39.x #2763

JonRowe opened this issue Jun 19, 2024 · 0 comments

Comments

@JonRowe
Copy link
Contributor

JonRowe commented Jun 19, 2024

👋 Thanks for all the hardwork team capybara!

We were debugging an issue with rspec-rails builds for Rails 7.1 on Ruby 2.7 (as we support the same matrix of Ruby as Rails does for each version) and it turned out it was due to the registration of the puma driver in capybara. Due to the change in minimum Ruby version for 3.40.0 we are forced to install 3.39.2 on Ruby 2.7 which lacks the patch from #2706.

We're attempting to patch this in our builds by overriding the puma driver but this means that "out of the box" Rails 7.1 with puma on 2.7 will still be broken, is there any chance of backporting the fix to a 3.39.3?

Meta

Capybara Version: 3.39.2

Expected Behavior

Freshly generated rails apps work with puma

Actual Behavior

 NameError:
     uninitialized constant Rack::Handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant