ODFValidator & Exit Code

[Progi1984]

Hi team members,

I would like to add ODFValidator to PHPPresentation for validating output files.

• #634 : Added ODFValidator PHPOffice/PHPPresentation#653

In my scenario, I would like that Github Actions fails if there are errors in validation.
But actually, if there errors or not the exit code equals 0.

[mistmist]

hmm the last time i considered this, i wrote:

commit b14e2f6

validator: return a status code indicating success or failure

It is a useful convention to return a failing status code in case
something went horribly wrong during execution, or the command line
arguments are invalid.  This can then be checked e.g. in LO's
test::BootstrapFixture.

(If validation errors are found, it was still a successful execution.)

... but maybe some people want to rely on the exit status to signal validation errors and some are bothered by that so maybe we could have a command line option --fail-on-validation-errors or something like that?

[Progi1984]

@mistmist It could be perfect. And that would allow to use in CI.

[Progi1984]

@sergey-s-betke Thanks for the PR.

@mistmist Sorry for disturbing you : I don't find a nightly build version on https://repo1.maven.org/maven2/org/odftoolkit/odfvalidator/. Where can I find it ?

[mistmist]

i dont think the CI we use uploads builds anywhere... you'll have to build from the "master" branch locally until there 0.10 release