Merge rust-bitcoin#192: Remove the check api infrastructure

0fc2533 Remove the check api infrastructure (Tobin C. Harding)

Pull request description:

  Turns out the check api stuff did not perform as we had hoped, remove the script and all the output files.

ACKs for top commit:
  apoelstra:
    ACK 0fc2533
  clarkmoody:
    ACK 0fc2533

Tree-SHA512: f9a3ccc39e648b5b1c645afc5f5aab0a1bb521c0c2774165fc151b7f6230f6f0c3fc7ea884101f9b053a4604ca7ed0e7ce4c9b09024ffe97de83728ae95dd0ae

Author: apoelstra

.github/workflows/rust.yml

@@ -140,18 +140,3 @@ jobs:
         run: cargo install cross --locked
       - name: run cross test
         run: cross test --target s390x-unknown-linux-gnu
-
-  API:
-    name: Check for changes to the public API
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-    steps:
-      - name: Checkout Crate
-        uses: actions/checkout@v3
-      - name: Checkout Toolchain
-        uses: dtolnay/rust-toolchain@nightly
-      - name: Install cargo-public-api
-        run: cargo install --locked cargo-public-api
-      - name: Running API checker script
-        run: ./contrib/check-for-api-changes.sh

README.md

@@ -33,10 +33,3 @@ Alternatively add symlinks in your `.git/hooks` directory to any of the githooks
 
 We use a custom Rust compiler configuration conditional to guard the benchmark code. To run the
 benchmarks use: `RUSTFLAGS='--cfg=bench' cargo +nightly bench`.
-
-
-## API changes
-
-All PRs that change the public API of `rust-bech32` must include a patch to the
-`api/` text files. For PRs that include API changes, add a separate patch to the PR
-that is the diff created by running `contrib/check-for-api-changes.sh`.

api/README.md

@@ -30,7 +30,3 @@ clippy:
 # run `cargo clippy --fix` on everything
 clippy-fix:
   cargo clippy --locked --offline --workspace --all-targets --fix
-
-# Check for API changes.
-check-api:
- contrib/check-for-api-changes.sh