Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding is not smooth when images are being lazy-loaded by nuxt-image and the CSS aspect-ratio is not there #33

Open
anton-karlovskiy opened this issue Feb 3, 2021 · 3 comments

Comments

@anton-karlovskiy
Copy link
Member

anton-karlovskiy commented Feb 3, 2021

After removing the CSS aspect-ratio, the transition does not work as expected.
Here are the changes https://github.com/addyosmani/nuxt-movies/pull/31/files and I believe there's not a special thing.

The transition working in the dev branch:
dev-branch

The transition seems broken in the perf/cls-with-nuxt-img branch:
perf cls-with-nuxt-img-branch

@pi0 @danielroe
Could you please give me advice on it?
cc @addyosmani

FYI: it's my bad, the transition is there.

@anton-karlovskiy
Copy link
Member Author

anton-karlovskiy commented Feb 3, 2021

There is something strange in sliding the cards carousel.
carousel-sliding

This is https://nuxt-movies-3wda5ahi3.vercel.app/ on the dev branch (with the CSS aspect-ratio) and this is https://nuxt-movies-qwn2u6az0.vercel.app/ on the perf/cls-with-nuxt-img branch (without the CSS aspect-ratio).

In the latter case, the sliding is not smooth.
@pi0 @danielroe Could you please give me advice on it? cc @addyosmani

@anton-karlovskiy anton-karlovskiy changed the title transition when images being lazy-loaded Sliding is not smooth when images are being lazy-loaded by nuxt-image and the CSS aspect-ratio is not there Feb 3, 2021
@addyosmani
Copy link
Member

In the latter case, the sliding is not smooth.

I can confirm that the sliding behavior in the second example is no longer smooth. It "appears" as though the images may be getting fetched sooner in the first example and there is less of a delay before the next set of images is displayed, while in the second example this feels a lot more noticeable.

@anton-karlovskiy
Copy link
Member Author

anton-karlovskiy commented Feb 17, 2021

@addyosmani @pi0

This bug was fixed in this PR.
I'm going to close this issue once you've confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants