-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coinbase extras #56
Milestone
Comments
4 tasks
stringhandler
pushed a commit
that referenced
this issue
Sep 24, 2024
Description --- Coinbase extra field is cached now (locally) and use other miners' coinbase extra when possible from share chain for their shares. Motivation and Context --- Coinbase extra field was not supported to be passed to p2pool before, so in order to let miners pass any extra data they want, we need to be able to do that. Specs for the format of p2pool coinbase extra field: #56 How Has This Been Tested? --- What process can a PR reviewer use to test or verify this change? --- <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [ ] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [x] Other - Please specify - P2pool should be updated at all clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add the ability to add a coinbase extra to the coinbases. Each miner can supply their coinbase extra and broadcast it as part of the share.
Squad data
The squad data must not be included in the coinbase extra when broadcasting shares, but when the local p2pool gets the template, it should add the squad to it's own coinbase using the following format:
1 byte 0xFF to say we are using Type-Length-Value
1 byte: 0x02 Type marker for squad
1 byte: The length of the squad-id,
n
n
bytes: The squad id1 byte: 0x01 Type marker for custom message
1 byte: length of custom message
m
m
bytes: custom message.The text was updated successfully, but these errors were encountered: