Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicaset downgrade: make version a positional argument #1076

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Dec 26, 2024

Closes #1073

@TarantoolBot
title: replicaset downgrade: make version a positional argument

@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from 9aa6392 to 76f67be Compare December 26, 2024 23:15
@elhimov elhimov added the full-ci Enables full ci tests label Dec 27, 2024
@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from 76f67be to 57a4c8f Compare December 27, 2024 09:30
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Please, fix a few things.

@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from 57a4c8f to 829ff7b Compare December 27, 2024 11:01
@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch 2 times, most recently from 23668d2 to d0a1699 Compare December 28, 2024 21:21
@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from d0a1699 to fcc0da9 Compare January 9, 2025 09:46
@oleg-jukovec oleg-jukovec requested a review from dmyger January 10, 2025 10:07
@oleg-jukovec
Copy link
Contributor

Please, fix a linter errors.

@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from fcc0da9 to df78c29 Compare January 11, 2025 11:04
Namely this commit fixes:
- resolveConnectOpts
- replicasetFillCtx

Part of #1075
@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from df78c29 to 74484d9 Compare January 13, 2025 09:32
Closes #1073

@TarantoolBot
title: replicaset downgrade: make version a positional argument

The option `-v` (`--version`) is no longer used.
@elhimov elhimov force-pushed the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch from 74484d9 to 3134b61 Compare January 13, 2025 14:46
@elhimov elhimov requested a review from oleg-jukovec January 13, 2025 16:00
@dmyger dmyger merged commit 84b0491 into master Jan 14, 2025
24 checks passed
@dmyger dmyger deleted the elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade branch January 14, 2025 12:48
@Totktonada
Copy link
Member

Please, create the documentation request manually: it seems that it is not created automatically due to the lowercased title word.

https://github.com/tarantool/docbot/blob/bda9b762eafa5181f378287619471c3bff4c6142/docbot/settings.py#L11

https://github.com/tarantool/docbot/blob/bda9b762eafa5181f378287619471c3bff4c6142/docbot/processors.py#L23-L24

@Totktonada
Copy link
Member

Filed tarantool/doc#4731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replicaset downgrade: specify version as positional argument instead of mandatory option
5 participants