-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replicaset downgrade: make version a positional argument #1076
Merged
dmyger
merged 2 commits into
master
from
elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade
Jan 14, 2025
Merged
replicaset downgrade: make version a positional argument #1076
dmyger
merged 2 commits into
master
from
elhimov/gh-1073-version-as-positional-argument-in-replicaset-downgrade
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9aa6392
to
76f67be
Compare
76f67be
to
57a4c8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch. Please, fix a few things.
57a4c8f
to
829ff7b
Compare
dmyger
reviewed
Dec 27, 2024
23668d2
to
d0a1699
Compare
patapenka-alexey
approved these changes
Dec 30, 2024
d0a1699
to
fcc0da9
Compare
Please, fix a linter errors. |
fcc0da9
to
df78c29
Compare
Namely this commit fixes: - resolveConnectOpts - replicasetFillCtx Part of #1075
df78c29
to
74484d9
Compare
dmyger
approved these changes
Jan 13, 2025
Closes #1073 @TarantoolBot title: replicaset downgrade: make version a positional argument The option `-v` (`--version`) is no longer used.
74484d9
to
3134b61
Compare
Please, create the documentation request manually: it seems that it is not created automatically due to the lowercased |
Filed tarantool/doc#4731. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1073
@TarantoolBot
title: replicaset downgrade: make version a positional argument