Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt pack завершается ошибкой при недоступном etcd #1038

Closed
tecl1s opened this issue Nov 27, 2024 · 3 comments · Fixed by #1066
Closed

tt pack завершается ошибкой при недоступном etcd #1038

tecl1s opened this issue Nov 27, 2024 · 3 comments · Fixed by #1066
Assignees
Labels
3sp bug Something isn't working teamE

Comments

@tecl1s
Copy link

tecl1s commented Nov 27, 2024

Описание

Команда tt pack tgz завершается ошибкой в случае недоступности etcd:

   ⨯ error collect applications info: failed to collect applications info: can't collect instance information for test_app: error loading instance "storage-002-a" configuration from config "/app/test/instances.enabled/test_app/config.yaml": unable to connect to etcd: context deadline exceeded

Команда tt pack должна разрешать выполнение в случае недоступности etcd в данный момент.

Репродьюссер

$ tt version
Tarantool CLI EE 2.4.0, linux/amd64. commit: d5f731b

$ tt create vshard_cluster --name test_app

$ cat >> test_app/config.yaml <<EOL
config:
  etcd:
    endpoints:
    - http://localhost:2379
    prefix: /test_app
    username: client
    password: secret
    http:
      request:
        timeout: 3
EOL

$ tt pack tgz --name test_app
⨯ error collect applications info: failed to collect applications info: can't collect instance information for test2_app: error loading instance "router-001-a" configuration from config "/app/test/instances.enabled/test_app/config.yaml": unable to connect to etcd: context deadline exceeded
@tecl1s tecl1s added the bug Something isn't working label Nov 27, 2024
@oleg-jukovec
Copy link
Contributor

Similar to #732 .

@patapenka-alexey
Copy link
Contributor

patapenka-alexey commented Dec 11, 2024

@oleg-jukovec I suggest to add new flag skip_config_from_etcd to the pack command to improve this condition.

@oleg-jukovec
Copy link
Contributor

@oleg-jukovec I suggest to add new flag skip_config_from_etcd to the pack command to improve this condition.

In theory there are no need at a config for tt pack at all.

patapenka-alexey added a commit that referenced this issue Dec 13, 2024
patapenka-alexey added a commit that referenced this issue Dec 16, 2024
patapenka-alexey added a commit that referenced this issue Dec 16, 2024
Closes #1038

@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.
patapenka-alexey added a commit that referenced this issue Dec 16, 2024
Closes #1038

@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
Part of #1038

@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
Part of #1038

@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
Part of #1038

@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Dec 23, 2024
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Dec 26, 2024
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Dec 26, 2024
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Dec 27, 2024
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Dec 27, 2024
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 3, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 3, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 8, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

skip config loading and script searching

debug
patapenka-alexey added a commit that referenced this issue Jan 9, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

skip config loading and script searching

debug

looks like status command should collect apps names

extract_status() do not work if --details flag is used
patapenka-alexey added a commit that referenced this issue Jan 9, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

skip config loading and script searching

debug

looks like status command should collect apps names

extract_status() do not work if --details flag is used

hmmm

skip config during tt status
patapenka-alexey added a commit that referenced this issue Jan 10, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 10, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

skip config loading and script searching

debug

looks like status command should collect apps names

extract_status() do not work if --details flag is used

hmmm

skip config during tt status

use iota to implement 3-way behaviour of cluster config loading
patapenka-alexey added a commit that referenced this issue Jan 10, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

skip config loading and script searching

debug

looks like status command should collect apps names

extract_status() do not work if --details flag is used

hmmm

skip config during tt status

use iota to implement 3-way behaviour of cluster config loading
patapenka-alexey added a commit that referenced this issue Jan 10, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

use iota to implement 3-way behaviour of cluster config loading
patapenka-alexey added a commit that referenced this issue Jan 10, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

use iota to implement 3-way behaviour of cluster config loading

python flake
patapenka-alexey added a commit that referenced this issue Jan 10, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 14, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 14, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038

rename and fix linter warnings

change configuration loading logic

apply less stronger condition for clean and logrotate
patapenka-alexey added a commit that referenced this issue Jan 14, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 14, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 14, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 15, 2025
From now on only the `check` and `start` commands do not skip errors
during cluster config generation from local, etcs/tcs and env
sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 15, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 15, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038

add unit test
patapenka-alexey added a commit that referenced this issue Jan 15, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 16, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 16, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 16, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 17, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 17, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 17, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 17, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
patapenka-alexey added a commit that referenced this issue Jan 17, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
patapenka-alexey added a commit that referenced this issue Jan 17, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
oleg-jukovec pushed a commit that referenced this issue Jan 20, 2025
@TarantoolBot document
Title: pack: skip configs from etcd and tcs

This patch fixes the `tt pack` error if `etcd` or `tcs` are unavailable
during package creation.

Part of #1038
oleg-jukovec pushed a commit that referenced this issue Jan 20, 2025
From now on `build`, `completion`, `kill`, `log`, `logrotate`, `stop`,
`list`, `pack` commands skip instance config generation from local,
etcs/tcs and env sources.

Closes #1038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3sp bug Something isn't working teamE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants