Skip to content

Commit f89bd5b

Browse files
themilchenkooleg-jukovec
authored andcommitted
ci: overwrite tmpdir in mac integration tests
The test `test_t3_instance_names_no_config` always fails because of very long path in tmpdir. This test requires socket path with fexed length, otherwise it can cause socket path buffer overflow. After the patch tmpdir was overwritten to the shorter one. Closes #931
1 parent 1998407 commit f89bd5b

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/full-ci.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,10 @@ jobs:
201201
- name: Run unit tests
202202
run: mage unitfull
203203

204+
# We need to override TMPDIR here because of the very long path in macOS tests
205+
# which causes a very long socket path error.
204206
- name: Integration tests
205-
run: mage integrationfull
207+
run: TMPDIR=/tmp mage integrationfull
206208

207209
# Etcd can be still running after integration tests when:
208210
# 1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)

.github/workflows/tests.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,10 @@ jobs:
197197
- name: Unit tests
198198
run: mage unit
199199

200+
# We need to override TMPDIR here because of the very long path in macOS tests
201+
# which causes a very long socket path error.
200202
- name: Run integration tests
201-
run: mage integration
203+
run: TMPDIR=/tmp mage integration
202204

203205
# Etcd can be still running after integration tests when:
204206
# 1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin)

0 commit comments

Comments
 (0)