Skip to content

Commit c8a4c81

Browse files
committed
create: do not create Dockerfile.* in app dir
Application docker files are not supported due to tt multi-application nature, and `docker` pack type is not supported yet. Do not create unnecessary files.
1 parent b237139 commit c8a4c81

File tree

7 files changed

+6
-148
lines changed

7 files changed

+6
-148
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

8+
## [Unreleased]
9+
10+
### Changed
11+
12+
- Do not create Dockerfile.* in application's directory.
13+
814
## [2.3.1] - 2024-06-13
915

1016
### Added

cli/create/create.go

-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ func Run(cliOpts *config.CliOpts, createCtx *create_ctx.CreateCtx) error {
6363
steps.RenderTemplate{},
6464
steps.RunHook{HookType: "post"},
6565
steps.Cleanup{},
66-
steps.CreateDockerfile{},
6766
steps.MoveAppDirectory{},
6867
steps.CreateAppSymlink{SymlinkDir: cliOpts.Env.InstancesEnabled},
6968
steps.PrintFollowUpMessage{Writer: os.Stdout},

cli/create/internal/steps/create_dockerfile.go

-47
This file was deleted.

cli/create/internal/steps/create_dockerfile_test.go

-66
This file was deleted.

cli/docker/common.go

-15
This file was deleted.

cli/docker/dockerfile.build.tt

-13
This file was deleted.

test/integration/create/test_create.py

-6
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ def test_create_basic_functionality(tt_cmd, tmpdir):
100100
# Check temporary files is removed.
101101
assert os.path.exists(os.path.join(app_path, "tmp_config.cfg")) is False
102102

103-
# Check default Dockerfile is created.
104-
assert os.path.exists(os.path.join(app_path, "Dockerfile.build.tt"))
105-
106103
# Check "--name" value is used in file name.
107104
assert os.path.exists(os.path.join(app_path, "app1.cfg"))
108105

@@ -555,9 +552,6 @@ def test_create_basic_functionality_with_yml_manifest(tt_cmd, tmpdir):
555552
# Check temporary files is removed.
556553
assert os.path.exists(os.path.join(app_path, "tmp_config.cfg")) is False
557554

558-
# Check default Dockerfile is created.
559-
assert os.path.exists(os.path.join(app_path, "Dockerfile.build.tt"))
560-
561555
# Check "--name" value is used in file name.
562556
assert os.path.exists(os.path.join(app_path, "app1.cfg"))
563557

0 commit comments

Comments
 (0)