Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depth to assert_covers #203

Closed
yngvar-antonsson opened this issue Dec 2, 2021 · 2 comments
Closed

Add depth to assert_covers #203

yngvar-antonsson opened this issue Dec 2, 2021 · 2 comments
Labels
5856 feature A new functionality

Comments

@yngvar-antonsson
Copy link
Contributor

Now it doesn't work:

t.assert_covers(
    {a = {b = 'c', d = 'e'}, f = 'g'}, 
    {a = {b = 'c'}}
)

Because {b = 'c', d = 'e'} ~= {b = 'c'}
I propose to add depth parameter to assert_covers to assert coverage of inner tables

@kyukhin kyukhin added feature A new functionality teamQ labels Dec 10, 2021
@sharonovd sharonovd added the 5856 label Dec 24, 2021
@Gerold103
Copy link

I faced the same issue while trying to use this assertion for vshard config tests. Please, bump the priority. This function is barely useful now except for trivial cases.

@locker
Copy link
Member

locker commented Aug 28, 2024

Done unconditionally (without a parameter) in:

@locker locker closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5856 feature A new functionality
Projects
None yet
Development

No branches or pull requests

6 participants