Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luacov problem with load() #249

Closed
Totktonada opened this issue Dec 10, 2021 · 0 comments · Fixed by #353
Closed

luacov problem with load() #249

Totktonada opened this issue Dec 10, 2021 · 0 comments · Fixed by #353
Labels
code health Improve code readability, simplify maintenance and so on good first issue Good for newcomers

Comments

@Totktonada
Copy link
Member

It seems, the following code confuses luacov:

crud/crud/common/utils.lua

Line 116 in 5e8c91e

flatten_func = assert(load(code, '@flatten', 't', env)) 

$ .rocks/bin/luacov .
Couldn't open flatten: No such file or directory

See tarantool/luatest#190 for details.
@Totktonada Totktonada added teamE code health Improve code readability, simplify maintenance and so on labels Dec 10, 2021
@Totktonada Totktonada mentioned this issue Dec 10, 2021
Closed
@Totktonada Totktonada added the good first issue Good for newcomers label Jun 1, 2022
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
coverage: fix loaded function name
fbba148 
Now we load flatten functions for spaces with `@flatten` source. Source
starting with @ assumes that it describes the file name, yet here it
isn't. Then luacov fails to find "flatten" file on coverage info build.

When we do not specify source explicitly, the whole string becames the
source. It will not confuse luacov anymore, and it's more helpful for
debug.

1. https://www.lua.org/manual/5.2/manual.html#pdf-load

Closes #249
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
coverage: fix loaded function name
3a5f9cc 
Now we load flatten functions for spaces with `@flatten` source. Source
starting with @ assumes that it describes the file name, yet here it
isn't. Then luacov fails to find "flatten" file on coverage info build.

When we do not specify source explicitly, the whole string becames the
source. It will not confuse luacov anymore (it just ignores them), and
it's more helpful for debug.

1. https://www.lua.org/manual/5.2/manual.html#pdf-load

Closes #249
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
coverage: fix loaded function name
c0ef1f6 
Now we load flatten functions for spaces with `@flatten` source. Source
starting with @ assumes that it describes the file name, yet here it
isn't. Then luacov fails to find "flatten" file on coverage info build.

When we do not specify source explicitly, the whole string becames the
source. It will not confuse luacov anymore (it just ignores them), and
it's more helpful for debug.

1. https://www.lua.org/manual/5.2/manual.html#pdf-load

Closes #249
@DifferentialOrange DifferentialOrange mentioned this issue Mar 24, 2023
Merged
1 task
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
coverage: fix loaded function name
8b19c30 
Now we load flatten functions for spaces with `@flatten` source. Source
starting with @ assumes that it describes the file name, yet here it
isn't. Then luacov fails to find "flatten" file on coverage info build.

When we do not specify source explicitly, the whole string became the
source. It will not confuse luacov anymore (it just ignores them), and
it's more helpful for debug.

1. https://www.lua.org/manual/5.2/manual.html#pdf-load

Closes #249
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
coverage: fix loaded function name
9253f70 
Now we load flatten functions for spaces with `@flatten` source. Source
starting with @ assumes that it describes the file name, yet here it
isn't. Then luacov fails to find "flatten" file on coverage info build.

When we do not specify source explicitly, the whole string became the
source. It will not confuse luacov anymore (it just ignores them), and
it's more helpful for debug.

1. https://www.lua.org/manual/5.2/manual.html#pdf-load

Closes #249
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
release: 1.1.1
e55b491 
Overview

  This release fixes a critical bug that resulted in 100% storage CPU
  load and fixes a couple of issues related to the development pipeline.

Changes
  * Rename `DEV` environment variable to
    `TARANTOOL_CRUD_ENABLE_INTERNAL_CHECKS` (#250).

Bugfixes
  * Yield on select/pairs storage tuple lookup (#312).
  * Fix loaded functions misleading coverage (#249).
@DifferentialOrange DifferentialOrange mentioned this issue Mar 24, 2023
Merged
DifferentialOrange added a commit that referenced this issue Mar 24, 2023
@DifferentialOrange
release: 1.1.1
57bcf8d 
Overview

  This release fixes a critical bug that resulted in 100% storage CPU
  load and fixes a couple of issues related to the development pipeline.

Changes
  * Rename `DEV` environment variable to
    `TARANTOOL_CRUD_ENABLE_INTERNAL_CHECKS` (#250).

Bugfixes
  * Yield on select/pairs storage tuple lookup (#312).
  * Fix loaded functions misleading coverage (#249).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

coverage: fix loaded function name tarantool/crud
1 participant
@Totktonada