Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide --arch flag #675

Open
DifferentialOrange opened this issue Jan 11, 2022 · 1 comment
Open

Provide --arch flag #675

DifferentialOrange opened this issue Jan 11, 2022 · 1 comment
Labels
feature A new functionality

Comments

@DifferentialOrange
Copy link
Member

Following #604

It is not possible to use any architecture in DEB/RPM than all/noarch. For example, https://github.com/google/rpmpack provides a flag for this case. I think it would be convenient for cartridge-cli too.

DifferentialOrange added a commit that referenced this issue Jan 11, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>-<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or ``--version`` value. After this patch,
``--version`` value is used as provided without normalization, so it
can be used to restore previous behavior for tar.gz artifact names
if needed.

Package architecture is `all`/`noarch`, so no new restrictions applied.
Restricting is not provided now, refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
2. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
DifferentialOrange added a commit that referenced this issue Jan 12, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>-<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or ``--version`` value. After this patch,
``--version`` value is used as provided without normalization, so it
can be used to restore previous behavior for tar.gz artifact names
if needed.

Package architecture is `all`/`noarch`, so no new restrictions applied.
Restricting is not provided now, refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
2. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
DifferentialOrange added a commit that referenced this issue Jan 12, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>-<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or ``--version`` value. After this patch,
``--version`` value is used as provided without normalization, so it
can be used to restore previous behavior for tar.gz artifact names
if needed.

Package architecture is `all`/`noarch`, so no new restrictions applied.
Restricting is not provided now, refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
2. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
@DifferentialOrange DifferentialOrange added feature A new functionality teamE labels Jan 12, 2022
@Totktonada
Copy link
Member

We also can scan for files of particular type (ELF).

DifferentialOrange added a commit that referenced this issue Jan 27, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>-<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or ``--version`` value. After this patch,
``--version`` value is used as provided without normalization, so it
can be used to restore previous behavior for tar.gz artifact names
if needed.

Package architecture is `all`/`noarch`, so no new restrictions applied.
Restricting is not provided now, refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
2. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
DifferentialOrange added a commit that referenced this issue Jan 31, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>_<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].<arch>.tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2, 3]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or ``--version`` value. Previously it was `X.Y.Z-N-gHASH`
if commits since tag and commit hash are provided, `X.Y.Z-N` if only
commits since tag is provided, `X.Y.Z-gHASH` if only commit hash
is provided, `X.Y.Z-0` if only version is provided.

After this patch, ``--version`` value is used as provided without
normalization. It can be used to set non-standard values (it still
should satisfy conventions).

Package architecture is `all` for DEB and `x86_64` for RPM and TGZ
to preserve backward compatibility. Restricting is not provided now,
refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
2. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
3. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
DifferentialOrange added a commit that referenced this issue Feb 4, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>_<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].<arch>.tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2, 3]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or ``--version`` value. Previously it was `X.Y.Z-N-gHASH`
if commits since tag and commit hash are provided, `X.Y.Z-N` if only
commits since tag is provided, `X.Y.Z-gHASH` if only commit hash
is provided, `X.Y.Z-0` if only version is provided.

After this patch, ``--version`` value is used as provided without
normalization. It can be used to set non-standard values (it still
should satisfy conventions).

Package architecture is `all` for DEB and `x86_64` for RPM and TGZ
to preserve backward compatibility. Restricting is not provided now,
refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
2. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
3. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
DifferentialOrange added a commit that referenced this issue Feb 4, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>_<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].<arch>.tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2, 3]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or non-transformed ``--version`` value. Previously it was
transformed to `X.Y.Z-N-gHASH` with ability to set `X.Y.Z-N`,
`X.Y.Z-gHASH` with `--version`.

After this patch, ``--version`` value is used as provided without
transformation. Previously it had the same restrictions and
transformations as `git describe --tags --long` output. It can be used
to set non-standard values (values still should satisfy conventions).

Package architecture is `all` for DEB and `x86_64` for RPM and TGZ
to preserve backward compatibility. Restricting is not provided now,
refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
2. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
3. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
DifferentialOrange added a commit that referenced this issue Feb 4, 2022
After this patch, artifact names will be as follows:
  * RPM: `<app-name>-<version>[.<suffix>]-1.<arch>.rpm`,
  * DEB: `<app-name>_<version>[.<suffix>]-1_<arch>.deb`,
  * TGZ: `<app-name>-<version>[.<suffix>].<arch>.tar.gz`.
With this change, RPM and DEB packages will satisfy naming
conventions [1, 2, 3]. `<version>` is `git describe` output normalized
to `X.Y.Z.N` or non-transformed ``--version`` value. Previously it was
transformed to `X.Y.Z-N-gHASH` with ability to set `X.Y.Z-N`,
`X.Y.Z-gHASH` with `--version`.

After this patch, ``--version`` value is used as provided without
transformation. Previously it had the same restrictions and
transformations as `git describe --tags --long` output. It can be used
to set non-standard values (values still should satisfy conventions).

Package architecture is `all` for DEB and `x86_64` for RPM and TGZ
to preserve backward compatibility. Restricting is not provided now,
refer to #675.

Since ``--version`` is no longer forced to be semantic, it may be used
to workaround #475.

1. https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
2. https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_debian_package_file_names
3. http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html

Closes #303, part of #475
@TarantoolBot TarantoolBot removed the teamE label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new functionality
Projects
None yet
Development

No branches or pull requests

3 participants