Skip to content

fix:refactor log messages in test cases to remove "successfully executed" for consistency #34422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanshengliang merged 2 commits into from
Jan 28, 2026
Merged

fix:refactor log messages in test cases to remove "successfully executed" for consistency #34422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d07ffe
fix:refactor log messages in test cases to remove "successfully execu…
tomchon Jan 28, 2026
84ab2bd
fix: correct syntax error in test_table_count_scan.py
tomchon Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion test/cases/01-DataTypes/test_column_tag_boundary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,5 +194,5 @@ def test_column_tag_boundary(self):
self.run_json_tag_boundary()

tdSql.execute("drop database db;")
tdLog.success("%s successfully executed" % __file__)


2 changes: 1 addition & 1 deletion test/cases/01-DataTypes/test_datatype_decimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2200,7 +2200,7 @@ def test_datatype_decimal(self):
#self.check_decimal_and_stream()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")


def wait_query_result(self, sql: str, expect_result, times):
for i in range(times):
Expand Down
2 changes: 1 addition & 1 deletion test/cases/01-DataTypes/test_datatype_decimal64.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2055,7 +2055,7 @@ def test_datatype_decimal64(self):
#self.check_decimal_and_stream()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")


def wait_query_result(self, sql: str, expect_result, times):
for i in range(times):
Expand Down
2 changes: 1 addition & 1 deletion test/cases/01-DataTypes/test_datatype_decimal_last.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2029,7 +2029,7 @@ def test_decimal3(self):
#self.check_decimal_and_stream() open when new strm ready

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")


def wait_query_result(self, sql: str, expect_result, times):
for i in range(times):
Expand Down
2 changes: 1 addition & 1 deletion test/cases/02-Databases/01-Create/test_db_compact_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def test_compact_meta(self):
self.run_case1()
self.run_case2()

tdLog.success("%s successfully executed" % __file__)


def run_case1(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion test/cases/02-Databases/01-Create/test_db_create_encrypt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,6 @@ def test_db_create_encrypt(self):
self.create_encrypt_sm4_db()
self.create_encrypt_aes_db()

tdLog.success(f"{__file__} successfully executed")



2 changes: 1 addition & 1 deletion test/cases/02-Databases/01-Create/test_db_retention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def do_retention_test(self):
time.sleep(10)

self._check_retention()
tdLog.success("%s successfully executed" % __file__)


print("do retention .......................... [passed]")

Expand Down
2 changes: 1 addition & 1 deletion test/cases/02-Databases/01-Create/test_db_wal_fsync_period.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,5 +239,5 @@ def test_db_wal_fsync_period(self):
tdLog.printNoPrefix("==========step4:after wal_level, all check again ")
self.all_test()

tdLog.success(f"{__file__} successfully executed")


2 changes: 1 addition & 1 deletion test/cases/02-Databases/01-Create/test_db_wal_level.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,5 +176,5 @@ def test_wal_level_skip(self):
time.sleep(2)
tdLog.info("restart taosd")
tdDnodes.start(1)
tdLog.success(f"{__file__} successfully executed")


2 changes: 1 addition & 1 deletion test/cases/02-Databases/01-Create/test_db_wal_retention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,5 +475,5 @@ def test_wal_retention(self):
self.run_test_db("db", checkTime = 3*60, wal_period = 60, wal_size_kb=500)


tdLog.success("%s successfully executed" % __file__)


1 change: 0 additions & 1 deletion test/cases/02-Databases/03-Alter/test_db_alter_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,3 @@ def test_db_alter_database(self):
self.alter_keep_time_offset()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")
2 changes: 1 addition & 1 deletion test/cases/02-Databases/03-Alter/test_db_alter_replica.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,4 +285,4 @@ def test_alter_replica(self):
self.alter_replica_31()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

4 changes: 2 additions & 2 deletions test/cases/02-Databases/08-Keep/test_keep_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ def check_create_db(self):
# check result
tdSql.query("select `keep_time_offset` from information_schema.ins_databases where name='db'")
tdSql.checkData(0, 0, hours)
tdLog.info("%s successfully executed" % __file__)


def check_old_syntax(self):
# old syntax would not support again
tdSql.error("alter dnode 1 'keeptimeoffset 10';")
tdLog.info("%s successfully executed" % __file__)



#
Expand Down
2 changes: 1 addition & 1 deletion test/cases/02-Databases/08-Keep/test_mlevel_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,5 @@ def test_mlevel_basic(self):
# check insert correct again
self.checkInsertCorrect()

tdLog.success(f"{__file__} successfully executed")


2 changes: 1 addition & 1 deletion test/cases/02-Databases/08-Keep/test_mlevel_except.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,5 +421,5 @@ def test_multilevel(self):
self.run_alter_disable_err_case()
self.run_alter_disable_case()

tdLog.success("%s successfully executed" % __file__)


2 changes: 1 addition & 1 deletion test/cases/02-Databases/08-Keep/test_mutil_stage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,4 +273,4 @@ def test_mutil_stage(self):
tdSql.execute(f"flush database {DBNAME}")

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/02-Databases/09-Stt/test_stt_blocks_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,4 @@ def test_stt_blocks_check(self):
self.stt_block_check()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/03-Tables/01-NormalTables/test_normaltable_100w.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,4 @@ def test_tb_100w_data_order(self):
"""
self.query_ntb_order_by_col(batch_num=1000, rows_count=1000000)

tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/03-Tables/02-SubTables/test_subtable_create_using_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,5 @@ def test_subtable_create_using_csv(self):
# check create ctb using csv file
self.check_create_ctb_using_csv_file()

tdLog.success(f"{__file__} successfully executed")


2 changes: 1 addition & 1 deletion test/cases/03-Tables/03-PrimaryKey/test_primary_key_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,5 +237,5 @@ def test_primary_key_create(self):
self.check_update_pk('s_table', TableType.SUPERTABLE)
self.check_update_pk('n_table', TableType.NORNALTABLE)

tdLog.success(f"{__file__} successfully executed")


1 change: 0 additions & 1 deletion test/cases/03-Tables/03-PrimaryKey/test_primary_key_delete.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,4 +253,3 @@ def test_primary_key_delete(self):
self.prepare_data(date_type[1])
self.check_delete_data_illegal(date_type[1])
self.check_delete_data()
tdLog.success(f"{__file__} successfully executed")
2 changes: 1 addition & 1 deletion test/cases/03-Tables/03-PrimaryKey/test_primary_key_insert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,4 +969,4 @@ def test_composite_primary_key_insert(self):
# while(True):
# self.test_stmt(LegalDataType.VARCHAR)

tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/01-Create/test_stable_create_keep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,5 +166,5 @@ def test_create_stb_keep(self):
# check stb keep ins table
self.check_stb_keep_ins_table()

tdLog.success(f"{__file__} successfully executed")


2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/01-Create/test_stable_create_presuf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,4 +577,4 @@ def test_stable_create_presuf(self):

endTime = time.time()
print("total time %ds" % (endTime - startTime))
tdLog.success("%s successfully executed" % __file__)

2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/01-Create/test_stable_create_rowlength64k.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,4 +1293,4 @@ def test_stable_create_rowlength64k(self):
endTime_all = time.time()
print("total time %ds" % (endTime_all - startTime_all))

tdLog.success(f"{__file__} successfully executed")

1 change: 0 additions & 1 deletion test/cases/04-SuperTables/01-Create/test_stable_create_rowlength64k_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,4 +174,3 @@ def test_rowlength64k_benchmark(self):

endTime_all = time.time()
print("total time %ds" % (endTime_all - startTime_all))
tdLog.success("%s successfully executed" % __file__)
2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/01-Create/test_stable_keep_compact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,6 @@ def test_super_table_keep_compact(self):
# 8. Test case 8: STB keep compact with database keep
self.run_case8_stb_keep_compact_with_db_keep()

tdLog.success(f"{__file__} successfully executed")



2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/01-Create/test_table_comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,4 @@ def test_table_comment(self):
self.comment_check_case(self.table_type_list,self.comment_flag_list)

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/01-Create/test_table_param_ttl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ def test_table_param_ttl(self):
self.ttl_check_ntb()
self.ttl_check_ctb()
self.ttl_check_insert()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/02-Drop/test_stable_drop_delfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,5 +170,5 @@ def test_delete_check(self):


# stop
tdLog.success("%s successfully executed" % __file__)


2 changes: 1 addition & 1 deletion test/cases/04-SuperTables/03-Alter/test_stable_alter_overall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,4 +341,4 @@ def test_alter_table(self):
self.alter_check_stb()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/05-VirtualTables/test_vtable_schema_is_old.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,6 @@ def test_vtable_schema_is_old(self):
self.run_unorderd_vtable_column_and_origin_table_column()
self.run_vtable_multi_columns_use_ts_column()
self.run_vstable_origin_table_column_has_same_prefix()
tdLog.success(f"{__file__} successfully executed")



4 changes: 2 additions & 2 deletions test/cases/06-DataIngestion/01-SQL/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def do_write_double(self):
tdLog.printNoPrefix("==========end case2 run ...............")

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")



#
Expand Down Expand Up @@ -248,7 +248,7 @@ def do_write_timestamp(self):
tdSql.execute("drop table if exists test_t ;")
tdSql.execute("drop stable if exists st;")
tdSql.execute("drop database if exists test_insert_timestamp;")
tdLog.success("%s successfully executed" % __file__)


def __convert_ts_to_date(self, ts: int) -> str:
dt_object = datetime.datetime.fromtimestamp(ts / 1e9)
Expand Down
2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_bugs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,4 +543,4 @@ def test_write_bug(self):
self.do_ts4479()


tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_column_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,4 +547,4 @@ def test_write_column_value(self):
self.__insert_query_ts5184()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def InsertDouble(self):
self.run_tags("t_small", "smallint", 16)
self.run_tags("t_tiny", "tinyint", 8)
tdLog.printNoPrefix("==========end case2 run ...............")
tdLog.info(f"{__file__} successfully executed")


def test_write_datatypes(self): # sourcery skip: extract-duplicate-method, remove-redundant-fstring
"""Write data types
Expand Down
11 changes: 1 addition & 10 deletions test/cases/06-DataIngestion/01-SQL/test_write_morevgroup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ def test_write_morevgroup(self):


#tdSql.close()
tdLog.success(f"{__file__} successfully executed")


# create database and tables。
self.check_case1()
Expand All @@ -372,12 +372,3 @@ def test_write_morevgroup(self):
# taosBenchmark：create database/table and insert data
self.check_case3()
tdLog.debug(" LIMIT test_case3 ............ [OK]")

tdLog.success("%s successfully executed" % __file__)



return
#
# add case with filename
#
2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_null_none.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,4 +2668,4 @@ def test_insert_null_none(self):
print("total time %ds" % (endTime - startTime))

#tdSql.close()
tdLog.success("%s successfully executed" % __file__)

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_perf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,4 +144,4 @@ def test_insert_perf(self):
self.check_insert(self.tb3, 1000, self.ts, 3, 3)

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_stb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,5 +636,5 @@ def test_insert_stb(self):
self.run_consecutive_seq()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")


2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/01-SQL/test_write_update_multi_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,4 +462,4 @@ def test_update_data_muti_rows(self):
# case2
self.do_update_data()

tdLog.success(f"{__file__} successfully executed")

10 changes: 5 additions & 5 deletions test/cases/06-DataIngestion/02-STMT/test_stmt_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def check_stmt_insert_multi(self,conn, asc = True):

# conn.execute("drop database if exists %s" % dbname)
# conn.close()
tdLog.success("%s successfully executed, asc:%s" % (__file__, asc))


except Exception as err:
# conn.execute("drop database if exists %s" % dbname)
Expand All @@ -164,7 +164,7 @@ def do_stmt_muti_insert_query(self):
self.check_stmt_insert_multi(connectstmt, True)
self.check_stmt_insert_multi(connectstmt, False)
self.clear_env(connectstmt)
tdLog.success(f"{__file__} successfully executed")

return

#
Expand Down Expand Up @@ -328,7 +328,7 @@ def check_stmt_set_tbname_tag(self,conn):

# conn.execute("drop database if exists %s" % dbname)
conn.close()
tdLog.success("%s successfully executed" % __file__)


except Exception as err:
# conn.execute("drop database if exists %s" % dbname)
Expand All @@ -342,7 +342,7 @@ def do_stmt_set_tbname_tag(self):
connectstmt=self.newcon(host,config)
self.check_stmt_set_tbname_tag(connectstmt)

tdLog.success(f"{__file__} successfully executed")


return

Expand Down Expand Up @@ -370,4 +370,4 @@ def test_stmt_basic(self):

self.do_stmt_muti_insert_query()
self.do_stmt_set_tbname_tag()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/02-STMT/test_write_stmt_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,4 +399,4 @@ def test_stmt_error(self):
else:
tdLog.exit("expect error(%s) not occured" % str(error))

tdLog.success("%s successfully executed" % __file__)

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/03-SML/test_write_sml_influxdb_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,4 +1383,4 @@ def test_write_sml_influxdb_line(self):
# self.test()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/03-SML/test_write_sml_opentsdb_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,4 +1810,4 @@ def test_write_sml_opentsdb_json(self):
raise err

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/03-SML/test_write_sml_opentsdb_telnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,4 +1510,4 @@ def test_write_sml_opentsdb_telnet(self):
except Exception as err:
print(''.join(traceback.format_exception(None, err, err.__traceback__)))
raise err
tdLog.success(f"{__file__} successfully executed")

2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/03-SML/test_write_sml_restart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,6 @@ def test_write_sml_restart(self):



tdLog.success(f"{__file__} successfully executed")



2 changes: 1 addition & 1 deletion test/cases/06-DataIngestion/03-SML/test_write_sml_ts3724.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,4 @@ def test_sml_TS_3724(self):
self.checkContent()

#tdSql.close()
tdLog.success(f"{__file__} successfully executed")

Loading
Loading