Skip to content

Commit c1410c5

Browse files
Copilotcadem
andcommitted
Address code review feedback
Co-authored-by: cadem <[email protected]>
1 parent 63519e5 commit c1410c5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

source/dnode/vnode/src/vnd/vnodeSvr.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3033,7 +3033,6 @@ static int32_t vnodeSaveOneAuditRecord(SVnode *pVnode, int64_t ver, SJson *pJson
30333033
// update metrics
30343034
METRICS_UPDATE(pVnode->writeMetrics.total_requests, METRIC_LEVEL_LOW, 1);
30353035
METRICS_UPDATE(pVnode->writeMetrics.total_rows, METRIC_LEVEL_HIGH, pSubmitRsp->affectedRows);
3036-
// METRICS_UPDATE(pVnode->writeMetrics.total_bytes, METRIC_LEVEL_LOW, pMsg->header.contLen);
30373036

30383037
if (tsEnableMonitor && tsMonitorFqdn[0] != 0 && tsMonitorPort != 0 && pSubmitRsp->affectedRows > 0 &&
30393038
strlen(RPC_MSG_USER(pOriginalMsg)) > 0 && tsInsertCounter != NULL) {
@@ -3069,13 +3068,13 @@ static int32_t vnodeProcessAuditRecordReq(SVnode *pVnode, int64_t ver, void *pRe
30693068
if (tDeserializeSVAuditRecordReq(pReq, len, &req) != 0) {
30703069
vError("vgId:%d, failed to deserialize SVAuditRecordReq", TD_VID(pVnode));
30713070
code = TSDB_CODE_INVALID_MSG;
3072-
return code;
3071+
TAOS_CHECK_GOTO(code, &lino, _exit);
30733072
}
30743073

30753074
if (req.data == NULL) {
30763075
vError("vgId:%d, audit record data is NULL", TD_VID(pVnode));
30773076
code = TSDB_CODE_INVALID_MSG;
3078-
return code;
3077+
TAOS_CHECK_GOTO(code, &lino, _exit);
30793078
}
30803079

30813080
vTrace("vgId:%d, start to process AuditRecord Req, data:%s", TD_VID(pVnode), req.data);
@@ -3128,9 +3127,10 @@ static int32_t vnodeProcessAuditRecordReq(SVnode *pVnode, int64_t ver, void *pRe
31283127
}
31293128

31303129
_exit:
3131-
if (code != 0)
3132-
vError("vgId:%d, failed to process AuditRecordReq failed at line:%d, since %s", TD_VID(pVnode), lino,
3130+
if (code != 0) {
3131+
vError("vgId:%d, failed to process AuditRecordReq at line:%d, since %s", TD_VID(pVnode), lino,
31333132
tstrerror(code));
3133+
}
31343134

31353135
// clear
31363136
if (pSchema) taosMemoryFree(pSchema);

0 commit comments

Comments
 (0)