Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix assign may lose precision warning & improve related logging #8553

Merged
merged 11 commits into from
Jun 24, 2024

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 24, 2024

Does these few things:

  1. Removed printing of "No DebugInfo Available". This is simply a lot of spam when printing IR. Don't print when there's nothing to print
  2. Improve debug info handling for things that doesn't have source correlation, by first searching the immediate preceding statements for debug info (so the user at least know the ballpark), and when that fails prints the callable name & statement id
  3. Fixed the issue within snode_writer that emits Assign may lose precision: unknown <- f32 like crazy. (The unknown type is caused by a missing type_check on the indexing expression)
  4. Use our exception system to emit more helpful warnings for load-to-store forwarding, e.g.:
[W 06/23/24 19:08:39.945 11791278] TaichiWarning
File "/Users/bobcao3/taichi/python/taichi/lang/matrix_ops.py", line 281, in _matmul_helper:
                mat_z[i, j] = mat_z[i, j] + mat_x[i, k] * mat_y[k, j]
                                            ^^^^^^^^^^^
Loading variable 937 before anything is stored to it.

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 8aff9d6
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6678e99e100aed0008776b9e
😎 Deploy Preview https://deploy-preview-8553--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bobcao3 bobcao3 changed the title [bug] Fix assign type warning [bug] Fix assign may lose precision warning & improve related logging Jun 24, 2024
@bobcao3 bobcao3 merged commit 37a0563 into taichi-dev:master Jun 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants