Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Matrix 3x3 eigen decomposition #4571

Merged
merged 8 commits into from
Mar 24, 2022
Merged

Conversation

FantasyVR
Copy link
Collaborator

@FantasyVR FantasyVR commented Mar 18, 2022

Related issue = #2293 #2208

@netlify
Copy link

netlify bot commented Mar 18, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit d6fa2d9
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/623acdcb833a23000a50add2
😎 Deploy Preview https://deploy-preview-4571--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

taichi/math/eig.h Outdated Show resolved Hide resolved
@FantasyVR FantasyVR marked this pull request as ready for review March 21, 2022 03:18
@FantasyVR FantasyVR requested review from Hanke98 and ltt1598 March 21, 2022 03:19
Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/taichi/_funcs.py Outdated Show resolved Hide resolved
tests/python/test_eig.py Outdated Show resolved Hide resolved
@yuanming-hu yuanming-hu merged commit e9a2791 into taichi-dev:master Mar 24, 2022
@FantasyVR FantasyVR deleted the eig3x3 branch March 24, 2022 09:36
@xiaolinmu
Copy link

In func sym_eig2x2, lambda1 and lambda2 should be modified, i.e., lambda1 = (tr + ti.sqrt(ti.abs(gap))) * 0.5, lambda2 = (tr - ti.sqrt(ti.abs(gap))) * 0.5;In " all(A1 == ti.Matrix.zero(dt, 2, 2)) and all(A1 == ti.Matrix.zero(dt, 2, 2))", the second A1 should be A2; In the following v1 and v2 , normalized() may be singular value, like [[1,0],[0,0]], it should be rewrited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants