[doc] Fix typo #3798
[doc] Fix typo #3798
Conversation
|
✔️ Deploy Preview for jovial-fermat-aa59dc canceled. 🔨 Explore the source changes: 6983403 🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/61b867d5742693000749bee3 |
| @@ -10,4 +10,4 @@ Taichi is developed mainly in C++17 and Python3. Please check out the [Developer | |||
|
|
|||
| Issues marked with ["welcome contribution"](https://github.com/taichi-dev/taichi/issues?q=is%3Aopen+is%3Aissue+label%3A%22welcome+contribution%22) are great places for starters. You can quickly get an idea of the entire workflow and how to join the community. | |||
|
|
|||
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for because of their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |||
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |||
There was a problem hiding this comment.
Choosing between "because of" and "for", I feel like "because of" is clearer here, given "for" has so many different meanings under different contexts. WDYT? @Vissidarte-Herman :-)
There was a problem hiding this comment.
Hahaha. Finally, I have a chance to prove you are misled!!!
"We still lack a concrete design or implementation roadmap for these projects.". The "for" here does not suggest a causal relationship.
There was a problem hiding this comment.
Oops. I originally suggested "These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for because of their complexity."
There was a problem hiding this comment.
I see. Thanks for the clarification. Does it make sense to add a "," between "for" and "because of" then, for better clarity?
There was a problem hiding this comment.
I see your concern. Adding a comma is not grammatical for "because of" and breaks down the logic flow (because it is part of the that- modifier).
How about:
"These are the projects that we would like to work on but still lack a decent design or implementation roadmap for (because of their complexity)."
This is the best from my end. WDYT?
There was a problem hiding this comment.
"These are the projects that we would like to work on but still lack a decent design or implementation roadmap for (because of their complexity)."
This is the best from my end. WDYT?
Sounds great!
| @@ -10,4 +10,4 @@ Taichi is developed mainly in C++17 and Python3. Please check out the [Developer | |||
|
|
|||
| Issues marked with ["welcome contribution"](https://github.com/taichi-dev/taichi/issues?q=is%3Aopen+is%3Aissue+label%3A%22welcome+contribution%22) are great places for starters. You can quickly get an idea of the entire workflow and how to join the community. | |||
|
|
|||
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for because of their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |||
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |||
There was a problem hiding this comment.
I see your concern. Adding a comma is not grammatical for "because of" and breaks down the logic flow (because it is part of the that- modifier).
How about:
"These are the projects that we would like to work on but still lack a decent design or implementation roadmap for (because of their complexity)."
This is the best from my end. WDYT?
| @@ -10,4 +10,4 @@ Taichi is developed mainly in C++17 and Python3. Please check out the [Developer | |||
|
|
|||
| Issues marked with ["welcome contribution"](https://github.com/taichi-dev/taichi/issues?q=is%3Aopen+is%3Aissue+label%3A%22welcome+contribution%22) are great places for starters. You can quickly get an idea of the entire workflow and how to join the community. | |||
|
|
|||
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for because of their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |||
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |||
There was a problem hiding this comment.
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a concrete design or implementation roadmap for their complexity. We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! | |
| **RFC**: We use the `RFC` (Request for Comments) mechanism to discuss and organize some of the more advanced and self-contained features. These are the projects that we would like to work on but still lack a decent design or implementation roadmap for (because of their complexity). We document these requests and the threaded proposals in the hope that we could provide the community with a good enough context and draw upon insights from the potentially passionate minds. You can find all the ongoing RFCs [here](https://github.com/taichi-dev/taichi/issues?q=is%3Aissue+is%3Aopen+label%3ARFC+), and you are also welcome to file new RFCs with us! |
There was a problem hiding this comment.
What's "for" for? Lack? In that case how about "lack for a design or impl roadmap"?
There was a problem hiding this comment.
Hmm, nope.
- The "for" I suggested is used to complete the that-modifying clause: It modifies the preceding noun phrase "a decent design or implementation roadmap". In other words, I think you want to say "we lack a decent design or implementation roadmap FOR these projects.
- Although "lack for" is grammatically correct, it didn't solve the above issue (which is to complete the that-modifying clause).
|
/rebase |
taichi-gardener
force-pushed
the
k-ye-patch-2
branch
from
6983403 to
7e18885
Compare
✅ Deploy Preview for docsite-preview canceled.
|
|
Does this still applies? |
|
Closing stale PR |
Related issue = #