Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] [lang] Restore ODOP support #1830

Closed
wants to merge 6 commits into from

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Sep 3, 2020

Related issue = #1827

[Click here for the format server]


The remove + restore, refactored away the self.classfunc and self.classkernel property completely.

@archibate archibate changed the base branch from master to archibate-odop September 3, 2020 15:28
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1830 (0cf6101) into archibate-odop (a2c7ee4) will increase coverage by 0.31%.
The diff coverage is 85.00%.

@@                Coverage Diff                 @@
##           archibate-odop    #1830      +/-   ##
==================================================
+ Coverage           43.26%   43.57%   +0.31%     
==================================================
  Files                  44       44              
  Lines                5991     6024      +33     
  Branches             1073     1076       +3     
==================================================
+ Hits                 2592     2625      +33     
- Misses               3245     3248       +3     
+ Partials              154      151       -3     
Impacted Files Coverage Δ
python/taichi/lang/kernel.py 70.69% <85.00%> (+1.08%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@k-ye
Copy link
Member

k-ye commented Sep 6, 2020

Again, please feel free to merge to experimental branches, as they impose no risk to master...

@archibate
Copy link
Collaborator Author

No, I will only merge after your approvement.
The point of such workflow is:
each PR into experimental branch is reviewed, so that we don't need review when merging experimental branch into master.
If you don't review this carefully, you'll have to review the final PR that merge into master, with a huge changeset.

@archibate
Copy link
Collaborator Author

Hello? My point for experimental branches is break PRs down. If you don't review the sub-PRs, then the workflow has no difference than a traditional monothonic PR.

@archibate
Copy link
Collaborator Author

Hello? I'm not using this workflow for fun. It requires you to review it, otherwise it's nothing different from traditional PRs.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2021

CLA assistant check
All committers have signed the CLA.

@bobcao3
Copy link
Collaborator

bobcao3 commented Jun 23, 2024

Closing stale PR

@bobcao3 bobcao3 closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants