-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] [lang] Restore ODOP support #1830
Conversation
Codecov Report
@@ Coverage Diff @@
## archibate-odop #1830 +/- ##
==================================================
+ Coverage 43.26% 43.57% +0.31%
==================================================
Files 44 44
Lines 5991 6024 +33
Branches 1073 1076 +3
==================================================
+ Hits 2592 2625 +33
- Misses 3245 3248 +3
+ Partials 154 151 -3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Again, please feel free to merge to experimental branches, as they impose no risk to |
No, I will only merge after your approvement. |
Hello? My point for experimental branches is break PRs down. If you don't review the sub-PRs, then the workflow has no difference than a traditional monothonic PR. |
Hello? I'm not using this workflow for fun. It requires you to review it, otherwise it's nothing different from traditional PRs. |
Closing stale PR |
Related issue = #1827
[Click here for the format server]
The remove + restore, refactored away the
self.classfunc
andself.classkernel
property completely.