Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider switching to the Device Management Kit library for Ledger connections #3754

Open
mhluongo opened this issue Dec 13, 2024 · 0 comments
Open

Consider switching to the Device Management Kit library for Ledger connections #3754

mhluongo opened this issue Dec 13, 2024 · 0 comments

Comments

@mhluongo
Copy link
Contributor

https://developers.ledger.com/docs/device-interaction/beginner/discover_and_connect
@mhluongo mhluongo mentioned this issue Dec 13, 2024
Merged
Shadowfiend added a commit that referenced this issue Dec 13, 2024
@Shadowfiend
Include the latest Ledger Nano X product ID (#3755)
ba6aeb3 
The latest version of Ledger Nano X firmware changes the product ID to
`0x4000`, breaking connections with newer devices.

I tested this patch locally with a newly updated Ledger Nano X, though I
haven't been able to test it with an older (pre-upgrade) Nano X.

The Ledger team suggests we move to the [Device Management
Kit](https://developers.ledger.com/docs/device-interaction/beginner/discover_and_connect).
I haven't had time to dig in further on whether the DMK connection flow
would work with WebUSB, and [opened an
issue](#3754) for later.

Latest build:
[extension-builds-3755](https://github.com/tahowallet/extension/suites/32049732661/artifacts/2319383990)
(as of Fri, 13 Dec 2024 20:47:52 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhluongo