Merge pull request #79 from tablexi/handle_nil_deleted_at_responses

Clean up handling of deleted records query

Author: danhodos

lib/restforce/db/cleaner.rb

@@ -42,7 +42,7 @@ def deleted_salesforce_ids
           @runner.before,
         )
 
-        response.deletedRecords.map(&:id)
+        response.map(&:id)
       end
 
       # Internal: Get the IDs of records which are in the larger collection

lib/restforce/db/client.rb

@@ -52,24 +52,22 @@ def initialize(**_)
       #     Time.now,
       #   )
       #
-      #   #=> #<Restforce::Mash
-      #          latestDateCovered="2015-05-18T22:31:00.000+0000"
-      #          earliestDateAvailable="2015-04-11T06:44:00.000+0000"
-      #          deletedRecords=[
-      #            #<Restforce::Mash
-      #              deletedDate="2015-05-18T22:31:17.000+0000"
-      #              id="a001a000001a5vOAAQ"
-      #            >
-      #          ]
-      #        >
+      #   #=> [
+      #         #<Restforce::Mash
+      #           deletedDate="2015-05-18T22:31:17.000+0000"
+      #           id="a001a000001a5vOAAQ"
+      #          >,
+      #       ]
       #
-      # Returns a Restforce::Mash with a `deletedRecords` key.
+      # Returns an Array of Restforce::Mash objects.
       def get_deleted_between(sobject, start_time, end_time = Time.now)
-        api_get(
+        response = api_get(
           "sobjects/#{sobject}/deleted",
           start: start_time.utc.iso8601,
           end: end_time.utc.iso8601,
-        ).body
+        )
+
+        Array(response.body["deletedRecords"])
       end
 
     end

test/lib/restforce/db/cleaner_test.rb

@@ -78,9 +78,9 @@
         let(:runner) { Restforce::DB::Runner.new(0, Time.now - 300) }
         let(:cleaner) { Restforce::DB::Cleaner.new(mapping, runner) }
         let(:dummy_response) do
-          Struct.new(:deletedRecords).new([
+          [
             Restforce::Mash.new(id: salesforce_id),
-          ])
+          ]
         end
 
         before do