Skip to content

Commit 3eddddb

Browse files
Fidesnoellarav3n11
Fidesnoella
authored and
rav3n11
committed
fix(frontend): handle uncategorized work type
- when backend sends null for work type show as uncategorized
1 parent 8de5646 commit 3eddddb

File tree

26 files changed

+155
-62
lines changed

26 files changed

+155
-62
lines changed

‎frontend-new/public/quiz.png‎

9.89 KB
Loading

‎frontend-new/src/auth/components/AuthHeader/__snapshots__/AuthHeader.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ exports[`AuthHeader tests should not render subtitle if not passed 1`] = `
1515
style="max-width: 60%; margin: 5% 10%;"
1616
/>
1717
<button
18-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-17dt6mt-MuiButtonBase-root-MuiIconButton-root"
18+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1trvwbj-MuiButtonBase-root-MuiIconButton-root"
1919
data-testid="auth-language-selector-f4d06e4b-0e0c-49c7-ad93-924c5ac89070"
2020
tabindex="0"
2121
title="Language Selector"
@@ -61,7 +61,7 @@ exports[`AuthHeader tests should render the AuthHeader 1`] = `
6161
style="max-width: 60%; margin: 5% 10%;"
6262
/>
6363
<button
64-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-17dt6mt-MuiButtonBase-root-MuiIconButton-root"
64+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1trvwbj-MuiButtonBase-root-MuiIconButton-root"
6565
data-testid="auth-language-selector-f4d06e4b-0e0c-49c7-ad93-924c5ac89070"
6666
tabindex="0"
6767
title="Language Selector"

‎frontend-new/src/auth/components/registrationCodeFormModal/__snapshots__/RegistrationCodeFormModal.test.tsx.snap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ exports[`RegistrationCodeFormModal renders correctly when modal is shown and cal
2222
tabindex="-1"
2323
>
2424
<button
25-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-cdx41z-MuiButtonBase-root-MuiIconButton-root"
25+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1krsqng-MuiButtonBase-root-MuiIconButton-root"
2626
data-testid="invitation-code-close-icon-f782907a-6904-482c-b148-3c6682bf7b54"
2727
tabindex="0"
2828
title="Close registration code form"

‎frontend-new/src/auth/components/requestInvitationCode/requestInvitationCodeFormModal/__snapshots__/RequestInvitationCodeFormModal.test.tsx.snap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ exports[`RequestInvitationCodeFormModal should render modal correctly when open
2929
Request access to Compass
3030
</h4>
3131
<button
32-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1rnk4us-MuiButtonBase-root-MuiIconButton-root"
32+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-756wqx-MuiButtonBase-root-MuiIconButton-root"
3333
data-testid="request-invitation-code-form-close-icon-54e2f585-4c25-47d5-9414-928cb63d30cd"
3434
tabindex="0"
3535
title="Close request invitation code form"

‎frontend-new/src/auth/pages/Login/__snapshots__/Login.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ exports[`Testing Login component it should show login form successfully 1`] = `
2222
style="max-width: 60%; margin: 5% 10%;"
2323
/>
2424
<button
25-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-17dt6mt-MuiButtonBase-root-MuiIconButton-root"
25+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1trvwbj-MuiButtonBase-root-MuiIconButton-root"
2626
data-testid="auth-language-selector-f4d06e4b-0e0c-49c7-ad93-924c5ac89070"
2727
tabindex="0"
2828
title="Language Selector"
@@ -317,7 +317,7 @@ exports[`Testing Login component should handle application login code 1`] = `
317317
style="max-width: 60%; margin: 5% 10%;"
318318
/>
319319
<button
320-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-17dt6mt-MuiButtonBase-root-MuiIconButton-root"
320+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1trvwbj-MuiButtonBase-root-MuiIconButton-root"
321321
data-testid="auth-language-selector-f4d06e4b-0e0c-49c7-ad93-924c5ac89070"
322322
tabindex="0"
323323
title="Language Selector"

‎frontend-new/src/chat/reaction/components/dislikeReasonPopover/__snapshots__/DislikeReasonPopover.test.tsx.snap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ exports[`ReactionReasonPopover render tests should render the popover with disab
1515
Please tell us what the issue is?
1616
</h6>
1717
<button
18-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1soxa02-MuiButtonBase-root-MuiIconButton-root"
18+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-pawek1-MuiButtonBase-root-MuiIconButton-root"
1919
data-testid="dislike-reason-popover-close-icon-button-9f3e2d1c-8b7a-4c6d-a5e9-2f1d8c7b3a4e"
2020
tabindex="0"
2121
title="close feedback"
@@ -125,7 +125,7 @@ exports[`ReactionReasonPopover render tests should render the reaction reason po
125125
Please tell us what the issue is?
126126
</h6>
127127
<button
128-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1soxa02-MuiButtonBase-root-MuiIconButton-root"
128+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-pawek1-MuiButtonBase-root-MuiIconButton-root"
129129
data-testid="dislike-reason-popover-close-icon-button-9f3e2d1c-8b7a-4c6d-a5e9-2f1d8c7b3a4e"
130130
tabindex="0"
131131
title="close feedback"

‎frontend-new/src/chat/reaction/components/reactionButtons/__snapshots__/ReactionButtons.test.tsx.snap‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ exports[`ReactionButtons render tests should render correctly when no reaction i
66
data-testid="reaction-buttons-container-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
77
>
88
<button
9-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
9+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
1010
data-testid="reaction-button-like-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
1111
tabindex="0"
1212
title="like"
@@ -28,7 +28,7 @@ exports[`ReactionButtons render tests should render correctly when no reaction i
2828
/>
2929
</button>
3030
<button
31-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
31+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
3232
data-testid="reaction-button-dislike-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
3333
tabindex="0"
3434
title="dislike"
@@ -58,7 +58,7 @@ exports[`ReactionButtons render tests should render the reaction buttons and sho
5858
data-testid="reaction-buttons-container-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
5959
>
6060
<button
61-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
61+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
6262
data-testid="reaction-button-like-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
6363
tabindex="0"
6464
title="like"
@@ -80,7 +80,7 @@ exports[`ReactionButtons render tests should render the reaction buttons and sho
8080
/>
8181
</button>
8282
<button
83-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
83+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
8484
data-testid="reaction-button-dislike-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
8585
tabindex="0"
8686
title="dislike"
@@ -110,7 +110,7 @@ exports[`ReactionButtons render tests should render the reaction buttons and sho
110110
data-testid="reaction-buttons-container-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
111111
>
112112
<button
113-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
113+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
114114
data-testid="reaction-button-like-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
115115
tabindex="0"
116116
title="like"
@@ -132,7 +132,7 @@ exports[`ReactionButtons render tests should render the reaction buttons and sho
132132
/>
133133
</button>
134134
<button
135-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
135+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
136136
data-testid="reaction-button-dislike-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
137137
tabindex="0"
138138
title="dislike"
@@ -162,7 +162,7 @@ exports[`ReactionButtons render tests should render the reaction buttons as disa
162162
data-testid="reaction-buttons-container-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
163163
>
164164
<button
165-
class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
165+
class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
166166
data-testid="reaction-button-like-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
167167
disabled=""
168168
tabindex="-1"
@@ -182,7 +182,7 @@ exports[`ReactionButtons render tests should render the reaction buttons as disa
182182
</svg>
183183
</button>
184184
<button
185-
class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-e66naw-MuiButtonBase-root-MuiIconButton-root"
185+
class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1672xf7-MuiButtonBase-root-MuiIconButton-root"
186186
data-testid="reaction-button-dislike-8d4e6f2c-9a3b-4c5d-b1e7-5f9d8a2b3c4e"
187187
disabled=""
188188
tabindex="-1"

‎frontend-new/src/consent/components/consentPage/__snapshots__/Consent.test.tsx.snap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ exports[`Testing Consent Page render tests it should show consent screen with bo
195195
style="max-width: 60%; margin: 5% 10%;"
196196
/>
197197
<button
198-
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-17dt6mt-MuiButtonBase-root-MuiIconButton-root"
198+
class="MuiButtonBase-root MuiIconButton-root MuiIconButton-colorPrimary MuiIconButton-sizeMedium css-1trvwbj-MuiButtonBase-root-MuiIconButton-root"
199199
data-testid="auth-language-selector-f4d06e4b-0e0c-49c7-ad93-924c5ac89070"
200200
tabindex="0"
201201
title="Language Selector"

‎frontend-new/src/experiences/experienceService/experiences.types.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ export interface Experience {
1919
experience_title: string;
2020
company: string;
2121
location: string;
22-
work_type: WorkType;
22+
work_type: WorkType | null;
2323
top_skills: Skill[];
2424
}

‎frontend-new/src/experiences/experiencesDrawer/ExperiencesDrawer.stories.tsx‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,15 @@ export const ShownWhenConversationCompleted = {
7777
conversationCompleted: true,
7878
},
7979
};
80+
81+
const ShownWithUncategorized_experiences = generateRandomExperiences(1);
82+
ShownWithUncategorized_experiences.forEach((experience) => {
83+
experience.work_type = null;
84+
});
85+
export const ShownWithUncategorizedExperiences = {
86+
args: {
87+
isOpen: true,
88+
experiences: ShownWithUncategorized_experiences,
89+
conversationCompleted: true,
90+
},
91+
};

0 commit comments

Comments
 (0)