Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated python snapshot has syntax error if artifact ends in single quote #159

Open
alex-harvey-z3q opened this issue Mar 8, 2021 · 0 comments

Comments

@alex-harvey-z3q
Copy link

It appears that the snapshots produced by this library are delimited by three single quotes. If, however, the snapshot data ends in a single quote, the file snapshots/test_SOMETHING.py ends up with a syntax error in it, and the following error message is seen:

...                                                                                                                                                  
    Export:                                                                                                                                                                       
      Name: !Sub '${AWS::StackName}-SQSQueue''''
                                               ^                                                                                                                                  
SyntaxError: EOL while scanning string literal                                                                                                                                    

This library perhaps should test the data for the delimiter to ensure this is avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant