Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail when there are unused snapshots #13

Closed
iamogbz opened this issue Dec 4, 2019 · 3 comments · Fixed by #77
Closed

Fail when there are unused snapshots #13

iamogbz opened this issue Dec 4, 2019 · 3 comments · Fixed by #77
Labels
feature request New feature or request
Milestone
v0.1.0

Comments

@iamogbz
Copy link
Collaborator

iamogbz commented Dec 4, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

When there are unused snapshots there should be a behaviour to fail the tests especially for running in ci.

Describe the solution you'd like

Fail when unused snapshots are detected.

Describe alternatives you've considered

Flag to fail in ci --ci.

Additional context
Add any other context or screenshots about the feature request here.
@iamogbz iamogbz mentioned this issue Dec 4, 2019
Merged
@noahnu
Copy link
Collaborator

noahnu commented Dec 9, 2019

I'd be in favour of having the plugin be "strict" by default and allow users to opt-out via some config or cli flags.

@noahnu noahnu added the feature request New feature or request label Dec 19, 2019
@noahnu
Copy link
Collaborator

noahnu commented Dec 27, 2019

How would you fail? / How would the failure be reported? This would happen outside of individual test cases

@iamogbz iamogbz mentioned this issue Dec 29, 2019
Merged
1 task
@iamogbz iamogbz self-assigned this Dec 29, 2019
@noahnu noahnu added this to the v1.0.0 milestone Dec 29, 2019
@noahnu
Copy link
Collaborator

noahnu commented Mar 8, 2020

Addresses syrusakbary/snapshottest#73

@iamogbz iamogbz removed their assignment Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

feat: fail unused snapshots syrupy-project/syrupy
2 participants
@noahnu @iamogbz