Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Submodule may fail for github-fetched modules #283

Open
dehall opened this issue Oct 7, 2020 · 0 comments
Open

View Submodule may fail for github-fetched modules #283

dehall opened this issue Oct 7, 2020 · 0 comments

Comments

@dehall
Copy link
Contributor

dehall commented Oct 7, 2020

When you open a module from a github branch, and click View Submodule, it tries to open the submodule by URL in a new window, which fails when the referenced submodule isn't in the builtin version of the modules.

We should
a) open a new tab within the app instead of a new window
b) fetch from the same github branch as the current module, when appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant