Error processing in container-phrasing.js with specific markup combination

[vnphanquang]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

[email protected], possibly [email protected]

Link to runnable example

https://github.com/vnphanquang/repro-mdast-util-to-markdown

Steps to reproduce

Reproduction

1. Clone the repository: https://github.com/vnphanquang/repro-mdast-util-to-markdown
2. Install dependencies (pnpm, yarn, npm)
3. Run script: node index.js

More information

Note

this reproduction does involve mdast-util-gfm, however stack trace points to mdast-util-to-markdown.

Given this input:

<table>
  <tbody>
    <tr>
      <td>
        <p>Paragraph 1</p>
        <p>
          <em><strong>Paragraph 2</strong></em>
        </p>
      </td>
    </tr>
  </tbody>
</table>

I suspect the key troubling markup is at <em><strong>Paragraph 2</strong></em>. However, it does require an odd combination of being inside a table and also having multiple paragraphs in td to trigger the observed error.

From my test, skipping...

mdast-util-to-markdown/lib/util/container-phrasing.js

Line 106 in ec4eaf0

before === results[results.length - 1].slice(-1)

...produces a successful output. That is:

- results[results.length - 1].slice(-1)
+ results[results.length - 1]?.slice(-1)

However, I lack knowledge of the codebase to determine whether this change produces other false positive. Happy to open PR if given direction.

Expected behavior

Should output output.md

Actual behavior

Error thrown as observed in console:

[..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-to-markdown/lib/util/container-phrasing.js:106
        before === results[results.length - 1].slice(-1)
                                               ^

TypeError: Cannot read properties of undefined (reading 'slice')
    at containerPhrasing ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-to-markdown/lib/util/container-phrasing.js:106:48)
    at Object.containerPhrasingBound [as containerPhrasing] ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-to-markdown/lib/index.js:138:10)
    at paragraph ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-to-markdown/lib/handle/paragraph.js:16:23)
    at containerPhrasing ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-to-markdown/lib/util/container-phrasing.js:50:11)
    at Object.containerPhrasingBound [as containerPhrasing] ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-to-markdown/lib/index.js:138:10)
    at handleTableCell ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-gfm-table/lib/index.js:216:25)
    at handleTableRowAsData ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-gfm-table/lib/index.js:279:23)
    at handleTableAsData ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-gfm-table/lib/index.js:255:23)
    at Object.handleTable ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/mdast-util-gfm-table/lib/index.js:191:26)
    at Object.one [as handle] ([..truncated]/node_modules/.pnpm/[email protected]/node_modules/zwitch/index.js:108:17)

Affected runtime and version

[email protected]

Affected package manager and version

[email protected]

Affected OS and version

Linux 6.6 Arch Linux

Build and bundle tools

other (please specify in steps to reproduce)

[wooorm]

Thanks for the repro!

It’s a bit of a weird case: p in td, as that isn’t allowed in GFM markdown itself. But it’s fine in HTML.

Anyway, good to add a guard to that check indeed!

[wooorm]

Released in https://github.com/syntax-tree/mdast-util-to-markdown/releases/tag/2.1.2!

[vnphanquang]

Thanks a lot @wooorm. That was super quick 🎉