Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve accuracy of "You will receive" amount in CJIT receive flow #2394

Open
catch-21 opened this issue Dec 10, 2024 · 0 comments
Labels
enhancement New feature or request feature request A user has an idea for the app

Comments

@catch-21
Copy link
Contributor

Describe the problem

During receive via CJIT flow, the "You will receive" value is now just an estimate due to recent changes preventing the correct amount being calculated. This is because Blocktank needs to know the LSP balance and client balance to calculate the fees, but the client balance is the amount minus the fees.

image

Describe the solution

Ideally, we show an accurate value in advance. If this is truly impossible then we could display a pessimistic value and hope no one cares enough about the inaccuracy because they got more than expected. Perhaps Blocktank can provide a worse-case yet still realistic value to use. Could also consider changing the text to "You will receive at least".

Additional context

No response

@catch-21 catch-21 added enhancement New feature or request feature request A user has an idea for the app labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request A user has an idea for the app
Projects
None yet
Development

No branches or pull requests

1 participant