Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Requesting max spending balance can break value input on Receiving Capacity page #2379

Closed
catch-21 opened this issue Nov 29, 2024 · 1 comment · Fixed by #2386
Closed

[Bug]: Requesting max spending balance can break value input on Receiving Capacity page #2379

catch-21 opened this issue Nov 29, 2024 · 1 comment · Fixed by #2386
Assignees
@pwltr
Labels
bug Something isn't working

Comments

@catch-21
Copy link
Contributor

Describe the bug

When maxing out the allowed liquidity in lightning connections, the Receiving Capacity page breaks. It doesn't let you set any value and proceed to tap Continue button, even when using the default value that would be used otherwise.

Reproduce

  1. Have enough onchain balance to exceed the lightning connection liquidity allowance
  2. Go to Transfer to Spending flow
  3. Before confirming the transfer, tap on Advanced button to go to Receiving Capacity screen
  4. Attempt to set any value
  5. Observe the Continue button never becomes enabled

Screenshots / Recording

Screenrecorder-2024-11-29-10-22-21-581.mp4

Operating system

Android 14

Bitkit version

release-v1.0.7 f0cde24

Log output

No response
@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels Nov 29, 2024
@catch-21 catch-21 changed the title [Bug]: Requesting max spending balance breaks Receiving Capacity page [Bug]: Requesting max spending balance can break value input on Receiving Capacity page Nov 29, 2024
@catch-21 catch-21 mentioned this issue Nov 29, 2024
Closed
@pwltr pwltr self-assigned this Dec 2, 2024
@pwltr pwltr removed the triage This issue needs to be looked over by the team label Dec 2, 2024
@pwltr pwltr mentioned this issue Dec 5, 2024
Merged
7 tasks
@pwltr pwltr linked a pull request Dec 5, 2024 that will close this issue
fix(transfer): update liquidity policy #2386
Merged
7 tasks
@catch-21
Copy link
Contributor Author

Verified on v1.0.8.
Tested on regtest. Receiving Capacity works well with a variety of 'transfer to spending' values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pwltr pwltr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transfer): update liquidity policy synonymdev/bitkit
2 participants
@pwltr @catch-21