Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notif user on Bitkit when he is Geoblock #2062

Closed
JeanlChristophe opened this issue Jul 15, 2024 · 8 comments
Closed

Notif user on Bitkit when he is Geoblock #2062

JeanlChristophe opened this issue Jul 15, 2024 · 8 comments
Assignees

Comments

@JeanlChristophe
Copy link

JeanlChristophe commented Jul 15, 2024

Description
Our users may be Geoblocked if they are geolocated in the countries that we block according to our ToS.

Issue
Users are not aware that they are geoban. ex: https://app.asana.com/0/1189635884316057/1207371335263354/f

Solution
Notify the user when he/she is using Blocktank and is Geoban. Please note that this notification must not be used when someone is using their own node or another LSP.
ps: Sometimes these users can be geoblocked because they are using a VPN, so be careful which country they are using.

@JeanlChristophe
Copy link
Author

note: they can not buy channel but they can do lightning transaction.

@catch-21
Copy link
Contributor

I have never been able to do a lightning transaction with US IP. Always get 'broadcast failed' error.
This is the reason why our E2E tests must use a VPN, because all GH runners are located in the US.

@aldertnl
Copy link
Contributor

I’m unclear on the specific limitations for U.S. and Canadian residents based on the above conversation. Are only channel purchases blocked (we have UI in place for this), or is Blocktank also unable to route any Lightning payments for these regions? If it’s the latter, here’s a potential toast notification.

image

@BitcoinErrorLog
Copy link
Contributor

Isnt this originally an issue with Blocktank blocking users from other things aside from buying a channel, like getting price or such? If so, the fix is isolate blocking by Blocktank to only blocking the generation of order invoices and blocking the direct opening of channels (for banned regions)

@catch-21
Copy link
Contributor

I observe that if Bitkit is launched with a European IP and then VPN switch to a US IP then lightning payments will still work but if Bitkit is launched with a US IP they do not work (unable to broadcast error) and continue to not work if then switched to European IP. It seems there is something in the LDK initialisation that determines whether payments are allowed.

@catch-21
Copy link
Contributor

@aldertnl
Copy link
Contributor

added more user feedback regarding geoblocks to prototype v52

@aldertnl aldertnl assigned JeanlChristophe and unassigned aldertnl Oct 22, 2024
@pwltr
Copy link
Collaborator

pwltr commented Dec 17, 2024

More UI for geoblocked users has been added in #2403

@pwltr pwltr closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants