From 0a48032181a84286b699a79a2943ae394feea87b Mon Sep 17 00:00:00 2001
From: Aaron Turner <synfinatic@gmail.com>
Date: Fri, 9 Aug 2024 16:59:32 -0700
Subject: [PATCH] Remove Firefox Multi-Account Containers plugin

This plugin doesn't support external URLs (anymore??) and so there is no way
to get this to work.

Fixes: #1021
---
 CHANGELOG.md   |  1 +
 docs/config.md | 31 +++++++++++++++++++++----------
 2 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3b02e82b..88d23725 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,7 @@
  * Only the and `cache` command will auto-update the contents of `~/.aws/config` #974
  * `tags` command no longer supports the `--force-update` option
  * Change default log level from `warn` to `info`
+ * Remove mention from docs that Firefox Multi-Account Containers plugin is supported #1021
 
 ### New Features
 
diff --git a/docs/config.md b/docs/config.md
index e784d18a..124f15a8 100644
--- a/docs/config.md
+++ b/docs/config.md
@@ -264,11 +264,8 @@ in a browser:
  * `open` -- Opens the URL in your default browser or the browser you specified
     via `--browser` or `Browser`
  * `open-url-in-container` -- Generates a URL for the Firefox [Open Url in Container](
-    https://addons.mozilla.org/en-US/firefox/addon/open-url-in-container/) and
-    [Firefox Multi-Account Containers](
-    https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/)
-    plugins and runs your `UrlExecCommand`. Please be sure to install only
-    one of these plugins. ;)
+    https://addons.mozilla.org/en-US/firefox/addon/open-url-in-container/)
+    plugin and runs your `UrlExecCommand`.
  * `print` -- Prints the URL with a message in your terminal to stderr
  * `printurl` -- Prints only the URL in your terminal to stderr
 
@@ -308,12 +305,10 @@ UrlExecCommand:
 
 ##### Open URL in Firefox Container
 
-Opens each IAM Role in a unique Firefox Container using either
+Opens each IAM Role (and SSO Login page) in a unique Firefox Container using the
 [Open Url in Container](
-https://addons.mozilla.org/en-US/firefox/addon/open-url-in-container/) or the
-[Firefox Multi-Account Containers](
-https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/)
-Firefox plugins.
+https://addons.mozilla.org/en-US/firefox/addon/open-url-in-container/)
+Firefox plugin.
 
 ```yaml
 UrlAction: open-url-in-container
@@ -322,6 +317,22 @@ UrlExecCommand:
     - "%s"
 ```
 
+**Note:** If you do not want your SSO Login page to be opened in a container,
+use the [AuthUrlAction](#authurlaction--browser--urlaction--urlexeccommand)
+option to specify a different action:
+
+```yaml
+SSOConfig:
+    Default:
+        SSORegion: us-east-1
+        StartUrl: https://example.awsapps.com/start
+        AuthUrlAction: open
+UrlAction: open-url-in-container
+UrlExecCommand:
+    - /Applications/Firefox.app/Contents/MacOS/firefox
+    - "%s"
+```
+
 ##### Use custom shell script
 
 ```yaml