Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configuring patches directory path #12

Open
siemova opened this issue Aug 1, 2023 · 3 comments · May be fixed by #13
Open

Enable configuring patches directory path #12

siemova opened this issue Aug 1, 2023 · 3 comments · May be fixed by #13

Comments

@siemova
Copy link

siemova commented Aug 1, 2023

Currently, the path to the "patches" directory is hard-coded in PatchFileFactory. I want to use ".composer/patches" instead, and I expect others have similar requirements, so it would be helpful to enable configuring that somewhere.
@TomasVotruba
Copy link
Member

Hi, that sounds reasonable.

Would you like to contribute this feature?
How would you implement it?

@siemova siemova linked a pull request Aug 17, 2023 that will close this issue
Open
@siemova
Copy link
Author

siemova commented Aug 17, 2023

I tried my hand at implementing this using an environment variable. If that is unacceptable for some reason, the alternative appears to be adding an optional parameter to the generate command. Please let me know what you think.

@TomasVotruba
Copy link
Member

Thanks for the kickoff. The command option would be better indeed, as clear entry point of the value. Could you handle it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support environment variable for patch output path siemova/vendor-patches
2 participants
@TomasVotruba @siemova