You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I have a monorepo and I added a package with classes that are used for writing integration tests much more easily. However, it seems symplify/monorepo-builder was ignoring this package because the name contained the string 'tests' in it.
Shouldn't this be at least configurable? It could be the default for the path exclude or maybe a test path exclude config?
It's not high priority to fix as I will fix it by just renaming the package for now.
The text was updated successfully, but these errors were encountered:
pjordaan
changed the title
Package with the name tests in the name are always ignored?
Package with the name 'tests' in the name are always ignored?
Sep 11, 2023
Hi,
I have a monorepo and I added a package with classes that are used for writing integration tests much more easily. However, it seems symplify/monorepo-builder was ignoring this package because the name contained the string 'tests' in it.
If I look in the source code I see a hardcoded if statement in PackageComposerFinder that is probably the culprit.
https://github.com/symplify/monorepo-builder/blob/main/src/Finder/PackageComposerFinder.php#L82
Shouldn't this be at least configurable? It could be the default for the path exclude or maybe a test path exclude config?
It's not high priority to fix as I will fix it by just renaming the package for now.
The text was updated successfully, but these errors were encountered: