Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SIL configs from dub.sdl. #85

Open
otrho opened this issue Jan 22, 2021 · 1 comment
Open

Remove SIL configs from dub.sdl. #85

otrho opened this issue Jan 22, 2021 · 1 comment

Comments

@otrho
Copy link
Contributor

otrho commented Jan 22, 2021

Having the SIL registration code in this repo introduces dependencies on sil-lang which are marked as optional in dub.sdl because there's a dub bug or something if they're not.

Ideally we should remove all the SIL stuff from here and keep it as just an IMAP D library and the SIL stuff can go in a dedicated plugin library hosted elsewhere which depends on this one.

@Laeeth
Copy link
Contributor

Laeeth commented Sep 26, 2023

Symmetry is welcome to remove the JMAP functionality but if it does so then I will have to fork it and put it up on code.dlang.org with JMAP and there will then be two forks with duplicated code, which I don't think is ideal.

I think it would be better either to open source Variable or to modify the code so it doesn't depend on Variable and you have an adaptor in the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants