Skip to content

Commit c1ec252

Browse files
committed
Enabling allowDeclareFields in Babel to use declare for properties
This is actually the propery way to do this in ts+Stimulus
1 parent 859b315 commit c1ec252

File tree

11 files changed

+63
-63
lines changed

11 files changed

+63
-63
lines changed

babel.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ module.exports = {
22
presets: [
33
['@babel/preset-env', {targets: {node: 'current'}}],
44
'@babel/react',
5-
'@babel/preset-typescript',
5+
['@babel/preset-typescript', { allowDeclareFields: true }]
66
],
77
};

src/Autocomplete/assets/src/controller.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ export default class extends Controller {
1313
preload: String,
1414
};
1515

16-
readonly urlValue: string;
17-
readonly optionsAsHtmlValue: boolean;
18-
readonly noMoreResultsTextValue: string;
19-
readonly noResultsFoundTextValue: string;
20-
readonly minCharactersValue: number;
21-
readonly tomSelectOptionsValue: object;
22-
readonly hasPreloadValue: boolean;
23-
readonly preloadValue: string;
16+
declare readonly urlValue: string;
17+
declare readonly optionsAsHtmlValue: boolean;
18+
declare readonly noMoreResultsTextValue: string;
19+
declare readonly noResultsFoundTextValue: string;
20+
declare readonly minCharactersValue: number;
21+
declare readonly tomSelectOptionsValue: object;
22+
declare readonly hasPreloadValue: boolean;
23+
declare readonly preloadValue: string;
2424
tomSelect: TomSelect;
2525

2626
initialize() {

src/Chartjs/assets/src/controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { Controller } from '@hotwired/stimulus';
1313
import Chart from 'chart.js/auto';
1414

1515
export default class extends Controller {
16-
readonly viewValue: any;
16+
declare readonly viewValue: any;
1717

1818
static values = {
1919
view: Object,

src/Cropperjs/assets/src/controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import Cropper from 'cropperjs';
1414
import CropEvent = Cropper.CropEvent;
1515

1616
export default class CropperController extends Controller {
17-
readonly publicUrlValue: string;
18-
readonly optionsValue: object;
17+
declare readonly publicUrlValue: string;
18+
declare readonly optionsValue: object;
1919

2020
static values = {
2121
publicUrl: String,

src/Dropzone/assets/src/controller.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
import { Controller } from '@hotwired/stimulus';
1313

1414
export default class extends Controller {
15-
readonly inputTarget: HTMLInputElement;
16-
readonly placeholderTarget: HTMLDivElement;
17-
readonly previewTarget: HTMLDivElement;
18-
readonly previewClearButtonTarget: HTMLButtonElement;
19-
readonly previewFilenameTarget: HTMLDivElement;
20-
readonly previewImageTarget: HTMLDivElement;
15+
declare readonly inputTarget: HTMLInputElement;
16+
declare readonly placeholderTarget: HTMLDivElement;
17+
declare readonly previewTarget: HTMLDivElement;
18+
declare readonly previewClearButtonTarget: HTMLButtonElement;
19+
declare readonly previewFilenameTarget: HTMLDivElement;
20+
declare readonly previewImageTarget: HTMLDivElement;
2121

2222
static targets = ['input', 'placeholder', 'preview', 'previewClearButton', 'previewFilename', 'previewImage'];
2323

src/LazyImage/assets/src/controller.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
import { Controller } from '@hotwired/stimulus';
1313

1414
export default class extends Controller {
15-
readonly srcValue: string;
16-
readonly srcsetValue: any;
17-
readonly hasSrcsetValue: boolean;
15+
declare readonly srcValue: string;
16+
declare readonly srcsetValue: any;
17+
declare readonly hasSrcsetValue: boolean;
1818

1919
static values = {
2020
src: String,

src/LiveComponent/assets/src/live_controller.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@ export default class extends Controller<HTMLElement> implements LiveController {
4040
fingerprint: String,
4141
};
4242

43-
readonly urlValue!: string;
44-
readonly dataValue!: any;
45-
readonly propsValue!: any;
46-
readonly csrfValue!: string;
47-
readonly hasDebounceValue: boolean;
48-
readonly debounceValue: number;
49-
readonly fingerprintValue: string;
43+
declare readonly urlValue: string;
44+
declare readonly dataValue: any;
45+
declare readonly propsValue: any;
46+
declare readonly csrfValue: string;
47+
declare readonly hasDebounceValue: boolean;
48+
declare readonly debounceValue: number;
49+
declare readonly fingerprintValue: string;
5050

5151
/** The component, wrapped in the convenience Proxy */
5252
private proxiedComponent: Component;

src/React/assets/src/render_controller.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ import { createRoot } from 'react-dom/client';
1414
import { Controller } from '@hotwired/stimulus';
1515

1616
export default class extends Controller {
17-
readonly componentValue?: string;
18-
readonly propsValue?: object;
17+
declare readonly componentValue?: string;
18+
declare readonly propsValue?: object;
1919

2020
static values = {
2121
component: String,

src/Swup/assets/src/controller.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@ import SwupFadeTheme from '@swup/fade-theme';
1717
import SwupSlideTheme from '@swup/slide-theme';
1818

1919
export default class extends Controller {
20-
animateHistoryBrowsingValue: boolean;
21-
hasAnimateHistoryBrowsingValue: boolean;
22-
animationSelectorValue: string;
23-
hasAnimationSelectorValue: boolean;
24-
cacheValue: boolean;
25-
hasCacheValue: boolean;
26-
containersValue: string[];
27-
mainElementValue: string;
28-
hasMainElementValue: boolean;
29-
linkSelectorValue: string;
30-
hasLinkSelectorValue: boolean;
31-
themeValue: string;
32-
debugValue: boolean;
20+
declare readonly animateHistoryBrowsingValue: boolean;
21+
declare readonly hasAnimateHistoryBrowsingValue: boolean;
22+
declare readonly animationSelectorValue: string;
23+
declare readonly hasAnimationSelectorValue: boolean;
24+
declare readonly cacheValue: boolean;
25+
declare readonly hasCacheValue: boolean;
26+
declare readonly containersValue: string[];
27+
declare readonly mainElementValue: string;
28+
declare readonly hasMainElementValue: boolean;
29+
declare readonly linkSelectorValue: string;
30+
declare readonly hasLinkSelectorValue: boolean;
31+
declare readonly themeValue: string;
32+
declare readonly debugValue: boolean;
3333

3434
static values = {
3535
animateHistoryBrowsing: Boolean,

src/Typed/assets/src/controller.ts

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -34,24 +34,24 @@ export default class extends Controller {
3434
contentType: { type: String, default: 'html' },
3535
};
3636

37-
readonly stringsValue!: string[];
38-
readonly typeSpeedValue: number;
39-
readonly smartBackspaceValue: boolean;
40-
readonly startDelayValue?: number;
41-
readonly backSpeedValue?: number;
42-
readonly shuffleValue?: boolean;
43-
readonly backDelayValue: number;
44-
readonly fadeOutValue?: boolean;
45-
readonly fadeOutClassValue: string;
46-
readonly fadeOutDelayValue: number;
47-
readonly loopValue?: boolean;
48-
readonly loopCountValue: number;
49-
readonly showCursorValue: boolean;
50-
readonly cursorCharValue: string;
51-
readonly autoInsertCssValue: boolean;
52-
readonly attrValue?: string;
53-
readonly bindInputFocusEventsValue?: boolean;
54-
readonly contentTypeValue: string;
37+
declare readonly stringsValue: string[];
38+
declare readonly typeSpeedValue: number;
39+
declare readonly smartBackspaceValue: boolean;
40+
declare readonly startDelayValue?: number;
41+
declare readonly backSpeedValue?: number;
42+
declare readonly shuffleValue?: boolean;
43+
declare readonly backDelayValue: number;
44+
declare readonly fadeOutValue?: boolean;
45+
declare readonly fadeOutClassValue: string;
46+
declare readonly fadeOutDelayValue: number;
47+
declare readonly loopValue?: boolean;
48+
declare readonly loopCountValue: number;
49+
declare readonly showCursorValue: boolean;
50+
declare readonly cursorCharValue: string;
51+
declare readonly autoInsertCssValue: boolean;
52+
declare readonly attrValue?: string;
53+
declare readonly bindInputFocusEventsValue?: boolean;
54+
declare readonly contentTypeValue: string;
5555

5656
connect() {
5757
const options = {

0 commit comments

Comments
 (0)