-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doctrine-bundle] v. 2.4 file does not exists docker-compose.yml
#1120
Comments
As you said, this is a warning and not an error. The |
But the file docker-compose.yml is changed for this recipe update. |
Do you use docker and docker-compose on your project? |
Yes |
So you should have a |
Please see above Maybe i am wrong. But the console output does say that. |
docker-composeyml
docker-compose.yml
I tried to upgrade from Symfony 6.2 to 6.3. The problem still exists. I already have a docker-composer.yml in the project root. Fortunatly a diff file is (or can be) created. But this also contains the filename without dot. Maybe someone has an idea why this happens.
|
This must be a general issue. I also get it when upgrading the symfony/mailer recipe. It then says: The file docker-composeoverrideyml was not updated because it doesn't exist in your app. For some reason, all dots are removed from the file name. So, I suppose the recipe update system is broken. |
yea, that's super weird. It, indeed, looks like something with the recipe update system is losing the EDIT: Nevermind, I see this locally as well... |
Fixed at symfony/flex#987 |
Thanks @weaverryan |
…rom the filename (weaverryan) This PR was merged into the 1.x branch. Discussion ---------- Fixing problem where rootDir is ".", which strips all dots from the filename Fixes symfony/recipes#1120 In a normal siutation, `$rootDir` is `.`. The intention of this code is to strip the "rootDir" from the START of the `$file` path, so that we are left with only the relative path. The `.` + `str_replace()` was too greedy, and was causing things like `docker-composeryaml`. The test uses an absolute root dir, and replicating the `.` would be tricky. But I tested this locally and the fix works. Cheers! Commits ------- 55d088e Fixinb problem where rootDir is ".", which strips all dots from the filename
I get the warning that the file does not exists
docker-composeyml
. (Missing .). Mac M1.The file
docker-compose.yml
does exist in my project.As it is correct in https://github.com/symfony/recipes/blob/b3395a2477b6d58089f92ef3a0d2e58226825a3a/doctrine/doctrine-bundle/2.4/manifest.json it is maybe a problem of the system itself?
`composer recipes:update doctrine/doctrine-bundle
Updating recipe for doctrine/doctrine-bundle...
Yes! Recipe updated!
The recipe was updated but with one or more conflicts.
Run git status to see them.
After resolving, commit your changes like normal.
NOTE:
The file docker-composeyml was not updated because it doesn't exist in your app.
Would you like to save the "diff" to a file so you can review it? (Y/n) Y
Saved diff to doctrine.doctrine-bundle.updates-for-deleted-files.patch
`
P.S. The post-install notice should be updated to postgres 14 as well.
https://github.com/symfony/recipes/blob/b3395a2477b6d58089f92ef3a0d2e58226825a3a/doctrine/doctrine-bundle/2.4/post-install.txt
Maybe this Line too. https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.4/config/packages/doctrine.yaml#L7
The text was updated successfully, but these errors were encountered: