Add more precise types in reusable test cases

Author: stof

Test/FormIntegrationTestCase.php

@@ -12,8 +12,12 @@
 namespace Symfony\Component\Form\Test;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Form\FormExtensionInterface;
 use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\Form\Forms;
+use Symfony\Component\Form\FormTypeExtensionInterface;
+use Symfony\Component\Form\FormTypeGuesserInterface;
+use Symfony\Component\Form\FormTypeInterface;
 
 /**
  * @author Bernhard Schussek <[email protected]>
@@ -32,21 +36,33 @@ protected function setUp(): void
             ->getFormFactory();
     }
 
+    /**
+     * @return FormExtensionInterface[]
+     */
     protected function getExtensions()
     {
         return [];
     }
 
+    /**
+     * @return FormTypeExtensionInterface[]
+     */
     protected function getTypeExtensions()
     {
         return [];
     }
 
+    /**
+     * @return FormTypeInterface[]
+     */
     protected function getTypes()
     {
         return [];
     }
 
+    /**
+     * @return FormTypeGuesserInterface[]
+     */
     protected function getTypeGuessers()
     {
         return [];

Test/TypeTestCase.php

@@ -13,6 +13,7 @@
 
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Form\FormBuilder;
+use Symfony\Component\Form\FormExtensionInterface;
 use Symfony\Component\Form\Test\Traits\ValidatorExtensionTrait;
 
 abstract class TypeTestCase extends FormIntegrationTestCase
@@ -28,6 +29,9 @@ protected function setUp(): void
         $this->builder = new FormBuilder('', null, $this->dispatcher, $this->factory);
     }
 
+    /**
+     * @return FormExtensionInterface[]
+     */
     protected function getExtensions()
     {
         $extensions = [];
@@ -39,11 +43,17 @@ protected function getExtensions()
         return $extensions;
     }
 
+    /**
+     * @return void
+     */
     public static function assertDateTimeEquals(\DateTime $expected, \DateTime $actual)
     {
         self::assertEquals($expected->format('c'), $actual->format('c'));
     }
 
+    /**
+     * @return void
+     */
     public static function assertDateIntervalEquals(\DateInterval $expected, \DateInterval $actual)
     {
         self::assertEquals($expected->format('%RP%yY%mM%dDT%hH%iM%sS'), $actual->format('%RP%yY%mM%dDT%hH%iM%sS'));

Tests/Extension/Core/Type/ChoiceTypeTranslationTest.php

@@ -27,7 +27,7 @@ class ChoiceTypeTranslationTest extends TypeTestCase
         'Roman' => 'e',
     ];
 
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         $translator = $this->createMock(TranslatorInterface::class);
         $translator->expects($this->any())->method('trans')

Tests/Extension/Core/Type/FileTypeTest.php

@@ -23,7 +23,7 @@ class FileTypeTest extends BaseTypeTestCase
 {
     public const TESTED_TYPE = 'Symfony\Component\Form\Extension\Core\Type\FileType';
 
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         return array_merge(parent::getExtensions(), [new CoreExtension(null, null, new IdentityTranslator())]);
     }

Tests/Extension/Csrf/Type/FormTypeCsrfExtensionTest.php

@@ -42,7 +42,7 @@ protected function setUp(): void
         parent::setUp();
     }
 
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         return array_merge(parent::getExtensions(), [
             new CsrfExtension($this->tokenManager, new IdentityTranslator()),

Tests/Extension/HtmlSanitizer/Type/TextTypeHtmlSanitizerExtensionTest.php

@@ -20,7 +20,7 @@
 
 class TextTypeHtmlSanitizerExtensionTest extends TypeTestCase
 {
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         $fooSanitizer = $this->createMock(HtmlSanitizerInterface::class);
         $fooSanitizer->expects($this->once())

Tests/Extension/PasswordHasher/Type/PasswordTypePasswordHasherExtensionTest.php

@@ -40,7 +40,7 @@ protected function setUp(): void
         parent::setUp();
     }
 
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         return array_merge(parent::getExtensions(), [
             new PasswordHasherExtension(new PasswordHasherListener($this->passwordHasher)),

Tests/Extension/Validator/Constraints/FormValidatorPerformanceTest.php

@@ -20,7 +20,7 @@
  */
 class FormValidatorPerformanceTest extends FormPerformanceTestCase
 {
-    protected function getExtensions()
+    protected function getExtensions(): array
     {
         return [
             new ValidatorExtension(Validation::createValidator(), false),