You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The client supports parallel downloads using HTTP Range Requests. Currently, the client assumes ranged requests are supported if and only if the server performs a redirect via a http.StatusSeeOther. Otherwise, c.singleStreamDownload is utilized:
// Library endpoint does not provide HTTP redirection response, treat as single stream, direct download
c.Logger.Logf("Library endpoint does not support concurrent downloads; reverting to single stream")
returnc.singleStreamDownload(ctx, dst, res, pb)
}
This negatively impacts download performance against servers that support ranged requests, but do not redirect via http.StatusSeeOther, and is the root cause of #129.
The current logic should be replaced with logic that detects HTTP range support in the standard fashion (ref).
The text was updated successfully, but these errors were encountered:
The client supports parallel downloads using HTTP Range Requests. Currently, the client assumes ranged requests are supported if and only if the server performs a redirect via a
http.StatusSeeOther
. Otherwise,c.singleStreamDownload
is utilized:scs-library-client/client/pull.go
Lines 273 to 278 in 2e30d58
This negatively impacts download performance against servers that support ranged requests, but do not redirect via
http.StatusSeeOther
, and is the root cause of #129.The current logic should be replaced with logic that detects HTTP range support in the standard fashion (ref).
The text was updated successfully, but these errors were encountered: