fix: [analyst-data:pull] Return early if there is nothing to pull

Author: mokaddem

app/Model/AnalystData.php

@@ -907,6 +907,9 @@ public function pull(array $user, ServerSyncTool $serverSync)
         }
 
         $allRemoteUUIDs = [];
+        if (empty($remoteData)) {
+            return 0;
+        }
         foreach (self::ANALYST_DATA_TYPES as $type) {
             $allRemoteUUIDs = array_merge($allRemoteUUIDs, array_keys($remoteData[$type]));
         }

tests/testlive_sync.py

@@ -87,7 +87,6 @@ def check_response(response):
 url = f'servers/pull/{remote_server["id"]}/disable_background_processing:1'
 pull_response = pymisp._check_response(pymisp._prepare_request('GET', url))
 check_response(pull_response)
-print(pull_response)
 assert "Pull completed. 0 events pulled, 0 events could not be pulled, 0 proposals pulled, 0 sightings pulled, 0 clusters pulled, 0 analyst data pulled." == pull_response["message"], pull_response["message"]
 
 # Test pull background