Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider context of image warnings #692

Open
sybrew opened this issue Nov 11, 2024 · 0 comments
Open

Consider context of image warnings #692

sybrew opened this issue Nov 11, 2024 · 0 comments
Labels
[Type] Enhancement Improves anything we already have.
Milestone

Comments

@sybrew
Copy link
Owner

sybrew commented Nov 11, 2024

In c73839e, I've added warning messages when selecting an inconsistently supported image extension.

This warning will also be shown when selecting an image for the sitemap logo or Local, which may not apply there.

Therefore, I already kept the warnings as generic as possible:

  • Warned: "The file extension "%s" is not supported on all platforms, preventing your image from being displayed."
  • Forbidden: "The file extension "%s" is not supported. Choose a different file."

'Warned' means that a social media platform doesn't support embedding the image. For example, Facebook or Discord don't support webp images.

'Forbidden' means that TSF filters the image from its output during sanitization. This process doesn't occur for all image display scenarios, creating the discrepancy and inaccuracy of the warnings.

@sybrew sybrew added the [Type] Enhancement Improves anything we already have. label Nov 11, 2024
@sybrew sybrew added this to the 5.1.1 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves anything we already have.
Projects
None yet
Development

No branches or pull requests

1 participant