Think through what should happen if all fragments in a visit already match the new URL

[hirasso]

Describe the problem 🧐

If all fragments in a visit already match visit.to.url, currently the matching fragment visit will simply be ignored, falling back to swups default containers for that visit.

That is not what would be expected. That kind of situation is basically like a link to the current page, even though the visit.from.url is not equal to visit.to.url.

Describe the propsed solution 😎

I've done a bit of research in #79 and then decided to first start with an issue.

I'm unsure about the ideal solution for the scenario described above. Maybe the behavior could be aligned with whatever is defined in swup.options.linkToSelf:

• if linkToSelf is scroll, nothing should happen (matching fragment visit, empty containers)
• if linkToSelf is set to navigate, the fragments should be reloaded (matching fragment visit with the containers of the matched rule)

As mentioned above, I'm not absolutely sure about the perfect solution here. Happy to talk it all through together.

Alternatives considered 🤔

Add a hook and always remove the fragment URL from the fragment element:

/** allow details to always be replaced */
swup.hooks.on("visit:end", () => {
  const detail = $<FragmentElement>("#detail")!;
  detail.__swupFragment!.url = "";
});

How important is this feature to you? 🧭

Would make my life a lot easier

Checked all these? 📚

• I have read and searched the official docs
• I have checked discussions and existing issues for related problems
• I agree to follow this project's Code of Conduct
• I have provided all necessary information to the best of my knowledge

[daun]

@hirasso Did the changes in #79 resolve this? Or is it still a thing?

[hirasso]

Yes, this was resolved. Take a look at https://filter-munich.com/calendar/ and click one of the items on the left multiple times. It will reload the fragment on the right, as that fragment already matches the current URL.

CleanShot.2024-11-25.at.12.19.50-small.mp4

[daun]

@hirasso Nice. How does it know to only reload the right-hand fragment, and not all of them?

[hirasso]

That's because the /event/:slug route only targets the container on the right.

[daun]

Ah, true!

[hirasso]

Thanks for reminding me to close this as completed :)