You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the beginning I would like to say that the project is very impressive. I am very grateful that you made it available online.
However, I have some doubts about the correctness of the loss function
we can find 0.5 * torch.log(epsilon + 1 - rho.pow(2))
If we refer to equation 24 from https://arxiv.org/pdf/1308.0850.pdf, it seems to me that we should have there rather
2 * torch.log(epsilon + 1 - rho.pow(2))
please let me know if I am wrong, if you used another repository please tell me which one.
Greetings once again.
The text was updated successfully, but these errors were encountered:
At the beginning I would like to say that the project is very impressive. I am very grateful that you made it available online.
However, I have some doubts about the correctness of the loss function
In lines
https://github.com/swechhachoudhary/Handwriting-synthesis/blob/f37fa68524f55257b7bef7df3246906625b01a0e/utils/model_utils.py#L31-L32
we can find 0.5 * torch.log(epsilon + 1 - rho.pow(2))
If we refer to equation 24 from https://arxiv.org/pdf/1308.0850.pdf, it seems to me that we should have there rather
2 * torch.log(epsilon + 1 - rho.pow(2))
please let me know if I am wrong, if you used another repository please tell me which one.
Greetings once again.
The text was updated successfully, but these errors were encountered: