Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss function #8

Open
aleksandersawicki opened this issue Oct 25, 2021 · 1 comment
Open

Loss function #8

aleksandersawicki opened this issue Oct 25, 2021 · 1 comment

Comments

@aleksandersawicki
Copy link

At the beginning I would like to say that the project is very impressive. I am very grateful that you made it available online.
However, I have some doubts about the correctness of the loss function

In lines
https://github.com/swechhachoudhary/Handwriting-synthesis/blob/f37fa68524f55257b7bef7df3246906625b01a0e/utils/model_utils.py#L31-L32

we can find 0.5 * torch.log(epsilon + 1 - rho.pow(2))

If we refer to equation 24 from https://arxiv.org/pdf/1308.0850.pdf, it seems to me that we should have there rather
2 * torch.log(epsilon + 1 - rho.pow(2))

please let me know if I am wrong, if you used another repository please tell me which one.

Greetings once again.

@bryandam
Copy link

@aleksandersawicki: I know I'm necroposting but did that change improve the output at all for you?

I tried with and without and neither seems to get it to create reasonable output. I couldn't even get it to match the output of the demo video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants