Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): Fix rkyv implementation of CacheCell #9714

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 5, 2024

@kdy1 kdy1 added this to the Planned milestone Nov 5, 2024
@kdy1 kdy1 self-assigned this Nov 5, 2024
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 734d620

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Nov 5, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/@babel/[email protected] ⚠︎
Critical CVE npm/[email protected] ⚠︎
Critical CVE npm/@babel/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #9714 will degrade performances by 3.58%

Comparing kdy1:wasm (734d620) with main (c135f71)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:wasm Change
es/visitor/base-perf/boxing_boxed_clone 2.4 µs 2.4 µs -3.58%

@kdy1 kdy1 marked this pull request as ready for review November 5, 2024 02:51
@kdy1 kdy1 requested a review from a team as a code owner November 5, 2024 02:51
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 5, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 5, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Nov 5, 2024
Copy link

Report too large to display inline

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant