Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Avoid generating reserved mangling names #9710

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

CPunisher
Copy link
Contributor

Description:

BREAKING CHANGE:

Related issue (if exists):

closes #9650

Copy user defined reserved to preserved_symbols, so the generated name will be skipped by

if preserved_symbols.contains(&sym) {

@CPunisher CPunisher requested a review from a team as a code owner November 4, 2024 11:43
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 5221f66

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Nov 4, 2024

CodSpeed Performance Report

Merging #9710 will not alter performance

Comparing CPunisher:fix/reserved (5221f66) with main (c135f71)

Summary

✅ 194 untouched benchmarks

@kdy1 kdy1 self-assigned this Nov 4, 2024
@kdy1 kdy1 added this to the Planned milestone Nov 4, 2024
kdy1
kdy1 previously approved these changes Nov 5, 2024
@kdy1 kdy1 requested a review from a team as a code owner November 5, 2024 07:26
@kdy1
Copy link
Member

kdy1 commented Nov 5, 2024

I'll merge this when I'm going to make a breaking change of swc_core!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Reserved Keywords Are Not Checked
2 participants