Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/common): Introduce pure Span and BytePos to handle #__PURE__ #9539

Merged
merged 18 commits into from
Sep 9, 2024

Conversation

magic-akari
Copy link
Member

Copy link

changeset-bot bot commented Sep 8, 2024

🦋 Changeset detected

Latest commit: ffe988e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Sep 8, 2024
Copy link

codspeed-hq bot commented Sep 8, 2024

CodSpeed Performance Report

Merging #9539 will degrade performances by 5.23%

Comparing magic-akari:feat/pure-span (ffe988e) with main (62ed065)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:feat/pure-span Change
es/full/codegen/es2015 275.4 µs 290.6 µs -5.23%

@magic-akari magic-akari marked this pull request as ready for review September 8, 2024 17:08
@magic-akari magic-akari requested review from a team as code owners September 8, 2024 17:08
@kdy1 kdy1 changed the title feat(es/common): Introduce pure Span and BytePos to handle #__PURE__ feat(es/common): Introduce pure Span and BytePos to handle #__PURE__ Sep 9, 2024
@kdy1 kdy1 merged commit f63a481 into swc-project:main Sep 9, 2024
24 checks passed
@magic-akari magic-akari deleted the feat/pure-span branch September 9, 2024 01:08
@kdy1 kdy1 removed this from the Planned milestone Sep 11, 2024
@kdy1 kdy1 added this to the v1.7.25 milestone Sep 11, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants