Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for node v10 and v12 #5348

Open
Meir017 opened this issue Jul 31, 2022 · 3 comments · May be fixed by #5355
Open

Drop support for node v10 and v12 #5348

Meir017 opened this issue Jul 31, 2022 · 3 comments · May be fixed by #5355
Labels
enhancement

Comments

@Meir017
Copy link

Meir017 commented Jul 31, 2022 •
edited
Loading

Describe the feature

Nodejs v10 and v12 are deprecated and not supported anymore, the oldest supported version is v14.
see https://nodejs.org/en/about/releases/
image

Changes here https://github.com/swc-project/swc/blob/main/package.json#L22

Babel plugin or link to the feature description

No response

Additional context

No response
@kwonoj
Copy link
Member

kwonoj commented Jul 31, 2022

I'm not sure what exact requirement for this. Do you mean we may document it somewhere? or explicitly drop something we currently do but shouldn't? I'm in support of dropping deprecated old versions though.

@Austaras
Copy link
Member

Austaras commented Aug 1, 2022 •
edited
Loading

Maybe here?

Meir017 added a commit to Meir017/swc that referenced this issue Aug 1, 2022
@Meir017
chore: Drop support for node v10 and v12
afb931b 
closes swc-project#5348
@Meir017 Meir017 linked a pull request Aug 1, 2022 that will close this issue
Open
@lexkrstn
Copy link

The problem is that any SWC version could be installed on Node v12 (which is still used in some of our legacy projects) now, but the most recent SWC versions don't support Node 12 in fact. So now I have to find the version that worked before the last dependency reinstallation in order to fix it in my package.json. As far as I understand how the package management works in NodeJs, I wouldn't need all this work if there was a proper engine version support indicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Drop support for node v10 and v12 Meir017/swc
4 participants
@kwonoj @lexkrstn @Meir017 @Austaras