From 1f90787ac5da276067c0ccccdd14514b8173f95b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20Gorej?= Date: Wed, 30 Oct 2024 11:06:29 +0100 Subject: [PATCH] chore: use Node.js@20.18.0 for dev environment (#4428) Refs #4033 --- .devcontainer/Dockerfile | 4 ++-- .nvmrc | 2 +- Dockerfile | 2 +- README.md | 2 +- package-lock.json | 4 ++-- package.json | 4 ++-- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 28ebd1af0..383069fed 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -1,8 +1,8 @@ ARG VARIANT="20-bookworm" FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:1-${VARIANT} -# Install 20.3.0 version of Node.js using nvm -ARG EXTRA_NODE_VERSION="20.3.0" +# Install 20.18.0 version of Node.js using nvm +ARG EXTRA_NODE_VERSION="20.18.0" RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}" ## install emscripten diff --git a/.nvmrc b/.nvmrc index 4adfbc353..2a393af59 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20.3.0 +20.18.0 diff --git a/Dockerfile b/Dockerfile index 7a7b8a286..0f005dea8 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM node:20.3.0-bookworm +FROM node:20.18.0-bookworm # use bash as default shell SHELL ["/bin/bash", "-c"] diff --git a/README.md b/README.md index ede6f80e7..dac4e6229 100644 --- a/README.md +++ b/README.md @@ -119,7 +119,7 @@ ApiDOM Playground is available at [https://swagger-api.github.io/apidom/](https: This is a monorepo for all ApiDOM packages. All the code is written in [TypeScript](https://www.typescriptlang.org/). All the information necessary for working with monorepo can be found in this [article](https://vladimirgorej.com/blog/things-i-have-learned-maintaining-javascript-monorepo-with-lerna/). -Assuming [prerequisites](#prerequisites) are already installed, [Node.js](https://nodejs.org/) `>=20.3.0` and `npm >=9.6.7` +Assuming [prerequisites](#prerequisites) are already installed, [Node.js](https://nodejs.org/) `>=20.18.0 <21` and `npm >=10.8.2` are the minimum required versions that this repo runs on, but we recommend using the latest version of Node.js@20. ### Setting up diff --git a/package-lock.json b/package-lock.json index 0f5021386..6ba821037 100644 --- a/package-lock.json +++ b/package-lock.json @@ -70,8 +70,8 @@ "webpack-cli": "=5.1.4" }, "engines": { - "node": "=20.3.0", - "npm": ">=9.6.7" + "node": "=20.18.0", + "npm": ">=10.8.2" } }, "node_modules/@adobe/css-tools": { diff --git a/package.json b/package.json index 12727e381..8611fedf4 100644 --- a/package.json +++ b/package.json @@ -9,8 +9,8 @@ "private": true, "type": "module", "engines": { - "node": "=20.3.0", - "npm": ">=9.6.7" + "node": "=20.18.0", + "npm": ">=10.8.2" }, "comments": { "scripts": {