Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeNavigate's navigation.complete promise never resolves or rejects when redirected #12486

Open
denovodavid opened this issue Jul 21, 2024 · 0 comments · May be fixed by #12896
Open

beforeNavigate's navigation.complete promise never resolves or rejects when redirected #12486

denovodavid opened this issue Jul 21, 2024 · 0 comments · May be fixed by #12896
Labels
bug Something isn't working

Comments

@denovodavid
Copy link

Describe the bug

beforeNavigate's navigation.complete promise never resolves or rejects when +page.js or +page.server.js uses redirect. onNavigate complete promise works, and afterNavigate also works.

Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-2kyvuj?file=src%2Froutes%2F%2Blayout.svelte

Logs

No response

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 8.02 GB / 15.96 GB
  Binaries:
    Node: 20.15.1 - ~\scoop\apps\nvs\current\nodejs\default\node.EXE
    npm: 10.7.0 - ~\scoop\apps\nvs\current\nodejs\default\npm.CMD
    pnpm: 9.1.2 - ~\scoop\apps\nvs\current\nodejs\default\pnpm.CMD
    bun: 1.1.20 - ~\scoop\shims\bun.EXE
  Browsers:
    Edge: Chromium (126.0.2592.113)

Severity

annoyance

Additional Information

No response
@eltigerchino eltigerchino added the bug Something isn't working label Oct 28, 2024
@eltigerchino eltigerchino linked a pull request Oct 28, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fulfil beforeNavigate complete when redirected sveltejs/kit
2 participants
@denovodavid @eltigerchino