Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging #12

Open
Odonno opened this issue Sep 22, 2023 · 1 comment
Open

Logging #12

Odonno opened this issue Sep 22, 2023 · 1 comment

Comments

@Odonno
Copy link
Contributor

Odonno commented Sep 22, 2023

  • [Question] Should we add some logging in the core library? In which functions?
  • Write a custom sink for Serilog. In a separate repository?
  • Support OpenTelemetry, if not already supported

Maybe @s-e-f has some ideas on this

@s-e-f
Copy link

s-e-f commented Sep 22, 2023

Logging and open telemetry sound like a good idea. Especially during the early days having logs can be very insightful to people learning how to use the package.

If we define all log events through the LoggerMessage attribute, all overhead will be kept to a minimum (practically non-existent if the logs don't pass the log level check).

OpenTelemetry requires some extra research from my part, will get back to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants