You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
They should be replaced by localization IDs ("namespace:some.key"), added to the locale files and the client should run the IDs through SupClient.i18n.t(...). Even better, it should enclose them in a descriptive string like Could not create project: ${reason} which should itself be locazlized.
The localized reasons should be full sentences (maybe multiple) so they should end with a full stop.
The text was updated successfully, but these errors were encountered:
Hmm, how do we deal with variable interpolation like here, since the localization happens on the client?
We should probably replace err: string with something like err: SupCore.LocalizedError and give it a constructor like new SupCore.LocalizedError("sceneEditor:errors.invalidActorId", { id }).
Both in
superpowers
andsuperpowers-game
, we have various error messages sent by the server through callbacks that haven't been internationalized.A couple examples:
They should be replaced by localization IDs (
"namespace:some.key"
), added to the locale files and the client should run the IDs throughSupClient.i18n.t(...)
. Even better, it should enclose them in a descriptive string likeCould not create project: ${reason}
which should itself be locazlized.The localized reasons should be full sentences (maybe multiple) so they should end with a full stop.
The text was updated successfully, but these errors were encountered: